Re: [PATCH v5 18/18] tests: Test qemuxmlactivetestThrottleGroup
On Mon, Nov 18, 2024 at 19:24:26 +0530, Harikumar R wrote:
From: Harikumar Rajkumar <harikumar.rajkumar(a)ibm.com>
Signed-off-by: Harikumar R <harirajkumar230(a)gmail.com>
---
tests/qemustatusxml2xmldata/throttlefilter-out.xml | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qemustatusxml2xmldata/throttlefilter-out.xml
b/tests/qemustatusxml2xmldata/throttlefilter-out.xml
index 2217ad929d..8751a42cce 100644
--- a/tests/qemustatusxml2xmldata/throttlefilter-out.xml
+++ b/tests/qemustatusxml2xmldata/throttlefilter-out.xml
@@ -231,6 +231,7 @@
</devices>
<libDir path='/var/lib/libvirt/qemu/domain-4-copy'/>
<channelTargetDir
path='/var/lib/libvirt/qemu/channel/target/domain-4-copy'/>
+ <memoryBackingDir path='/var/lib/libvirt/qemu/ram/4-copy'/>
<chardevStdioLogd/>
<allowReboot value='yes'/>
<nodename index='0'/>
Ah so this explains the failure in 13/18. As noted in our guidelines
tests must pass after every commit, so this kind of fix up later on is
not the correct fix.
I'll start a proper review of these patches once I close up few other
things, so please be patient. This feature is rather complex and thus
potentially involves maintenance burden on the maintainers so I'll need
to make sure it's as minimal as possible.