Re: [libvirt] [PATCH] build: Fix uninstall when WITH_APPARMOR_PROFILES is defined
On Tue, 2018-11-13 at 12:04 -0700, Jim Fehlig wrote:
On 11/13/18 10:14 AM, Andrea Bolognani wrote:
> > +uninstall-apparmor-local:
> > + rm -f "$(APPARMOR_LOCAL_DIR)/usr.lib.libvirt.virt-aa-helper"
> > + rmdir $(APPARMOR_LOCAL_DIR) || :
>
> Missing quotes here as well. Once you fix that,
>
> Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
I've fixed it and pushed. While doing so I noticed a lot of pre-existing lack of
quoting throughout the various Makefile.am :-). I'm not sure these are worth
fixing given the lack problem reports...
I'd say fixing them is worthwhile, so if you feel like putting time
into doing so I'll very happily review the resulting patches.
--
Andrea Bolognani / Red Hat / Virtualization