On 03/07/2012 12:45 AM, Guannan Ren wrote:
Subject: [PATCH] rpc: generalize solution for VPATH builds
Commit 5d4b0c4c80 tried to fix certain classes of VPATH builds, but was too limited. In particular, Guannan Ren reported:
For example: The libvirt source code resides in /home/testuser, I make dist in /tmp/buildvpath, the XDR routine .c
file will
include full path of the header file like:
#include "/home/testuser/src/rpc/virnetprotocol.h" #include "internal.h" #include<arpa/inet.h>
If we distribute the tarball to another machine to compile, it will report error as follows:
rpc/virnetprotocol.c:7:59: fatal error: /home/testuser/src/rpc/virnetprotocol.h: No such file or directory
It works great, so ACK here.
Thanks; pushed. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org