[libvirt PATCH] Drop YouCompleteMe and color_coded integration

I introduced support for these vim plugins several years ago but have since moved away from them. These days developers are likely better served by lsp-based tooling, which doesn't require additional per-project configuration. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com&gt; --- .color_coded.in | 38 --------------------------------- .ycm_extra_conf.py.in | 43 -------------------------------------- build-aux/syntax-check.mk | 1 - docs/developer-tooling.rst | 13 ------------ docs/hacking.rst | 1 - docs/meson.build | 1 - meson.build | 19 ----------------- 7 files changed, 116 deletions(-) delete mode 100644 .color_coded.in delete mode 100644 .ycm_extra_conf.py.in delete mode 100644 docs/developer-tooling.rst diff --git a/.color_coded.in b/.color_coded.in deleted file mode 100644 index f39c6860ab..0000000000 --- a/.color_coded.in +++ /dev/null @@ -1,38 +0,0 @@ --I@abs_top_builddir@ --I@abs_top_srcdir@ --I@abs_top_builddir@/include --I@abs_top_srcdir@/include --I@abs_top_builddir@/src --I@abs_top_srcdir@/src --I@abs_top_builddir@/src/access --I@abs_top_srcdir@/src/access --I@abs_top_builddir@/src/admin --I@abs_top_srcdir@/src/admin --I@abs_top_builddir@/src/bhyve --I@abs_top_srcdir@/src/bhyve --I@abs_top_builddir@/src/conf --I@abs_top_srcdir@/src/conf --I@abs_top_builddir@/src/libxl --I@abs_top_srcdir@/src/libxl --I@abs_top_builddir@/src/locking --I@abs_top_srcdir@/src/locking --I@abs_top_builddir@/src/logging --I@abs_top_srcdir@/src/logging --I@abs_top_builddir@/src/lxc --I@abs_top_srcdir@/src/lxc --I@abs_top_builddir@/src/qemu --I@abs_top_srcdir@/src/qemu --I@abs_top_builddir@/src/remote --I@abs_top_srcdir@/src/remote --I@abs_top_builddir@/src/rpc --I@abs_top_srcdir@/src/rpc --I@abs_top_builddir@/src/secret --I@abs_top_srcdir@/src/secret --I@abs_top_builddir@/src/security --I@abs_top_srcdir@/src/security --I@abs_top_builddir@/src/util --I@abs_top_srcdir@/src/util --I@abs_top_builddir@/src/vmx --I@abs_top_srcdir@/src/vmx --I@abs_top_builddir@/src/xenconfig --I@abs_top_srcdir@/src/xenconfig diff --git a/.ycm_extra_conf.py.in b/.ycm_extra_conf.py.in deleted file mode 100644 index 2e24334079..0000000000 --- a/.ycm_extra_conf.py.in +++ /dev/null @@ -1,43 +0,0 @@ -flags = [ - '-I@abs_top_builddir@', - '-I@abs_top_srcdir@', - '-I@abs_top_builddir@/include', - '-I@abs_top_srcdir@/include', - '-I@abs_top_builddir@/src', - '-I@abs_top_srcdir@/src', - '-I@abs_top_builddir@/src/access', - '-I@abs_top_srcdir@/src/access', - '-I@abs_top_builddir@/src/admin', - '-I@abs_top_srcdir@/src/admin', - '-I@abs_top_builddir@/src/bhyve', - '-I@abs_top_srcdir@/src/bhyve', - '-I@abs_top_builddir@/src/conf', - '-I@abs_top_srcdir@/src/conf', - '-I@abs_top_builddir@/src/libxl', - '-I@abs_top_srcdir@/src/libxl', - '-I@abs_top_builddir@/src/locking', - '-I@abs_top_srcdir@/src/locking', - '-I@abs_top_builddir@/src/logging', - '-I@abs_top_srcdir@/src/logging', - '-I@abs_top_builddir@/src/lxc', - '-I@abs_top_srcdir@/src/lxc', - '-I@abs_top_builddir@/src/qemu', - '-I@abs_top_srcdir@/src/qemu', - '-I@abs_top_builddir@/src/remote', - '-I@abs_top_srcdir@/src/remote', - '-I@abs_top_builddir@/src/rpc', - '-I@abs_top_srcdir@/src/rpc', - '-I@abs_top_builddir@/src/secret', - '-I@abs_top_srcdir@/src/secret', - '-I@abs_top_builddir@/src/security', - '-I@abs_top_srcdir@/src/security', - '-I@abs_top_builddir@/src/util', - '-I@abs_top_srcdir@/src/util', - '-I@abs_top_builddir@/src/vmx', - '-I@abs_top_srcdir@/src/vmx', - '-I@abs_top_builddir@/src/xenconfig', - '-I@abs_top_srcdir@/src/xenconfig', -] - -def FlagsForFile(filename, **kwargs): - return { 'flags': flags, 'do_cache': True } diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index a8c9153b20..fac1338589 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -921,7 +921,6 @@ http_sites += www.javvin.com # 404 links http_sites += publib.boulder.ibm.com http_sites += kerneltrap.org -http_sites += valloric.github.io http_sites += www.microsoft.com http_sites += xenbits.xen.org http_sites += lovezutto.googlepages.com diff --git a/docs/developer-tooling.rst b/docs/developer-tooling.rst deleted file mode 100644 index c8980e3e4f..0000000000 --- a/docs/developer-tooling.rst +++ /dev/null @@ -1,13 +0,0 @@ -================= -Developer tooling -================= - -libvirt includes support for some useful development tools right -in its source repository, meaning users will be able to take -advantage of them without little or no configuration. Examples -include: - -- `color_coded <https://github.com/jeaye/color_coded>`__, a vim - plugin for libclang-powered semantic syntax highlighting; -- `YouCompleteMe <http://valloric.github.io/YouCompleteMe/>`__, a - vim plugin for libclang-powered semantic code completion. diff --git a/docs/hacking.rst b/docs/hacking.rst index cd009c4c73..1be9daab80 100644 --- a/docs/hacking.rst +++ b/docs/hacking.rst @@ -72,7 +72,6 @@ This page only covers the very basics, so it's recommended that you also take a look at the following documents: - `Programming languages <programming-languages.html>`__ -- `Developer tooling <developer-tooling.html>`__ - `Advanced test suite usage <advanced-tests.html>`__ - `Adoption of GLib APIs <glib-adoption.html>`__ - `Committer guidelines <committer-guidelines.html>`__ diff --git a/docs/meson.build b/docs/meson.build index 7e070d68ad..690715a12e 100644 --- a/docs/meson.build +++ b/docs/meson.build @@ -95,7 +95,6 @@ docs_rst_files = [ 'committer-guidelines', 'compiling', 'daemons', - 'developer-tooling', 'drvqemu', 'drvch', 'formatbackup', diff --git a/meson.build b/meson.build index 519a928c9a..987d8a393f 100644 --- a/meson.build +++ b/meson.build @@ -2215,25 +2215,6 @@ configure_file( run_command('chmod', 'a+x', meson.current_build_dir() / 'run', check: true) -# generate developer tooling files -tooling_files = [ - '.color_coded.in', - '.ycm_extra_conf.py.in', -] - -tooling_conf = configuration_data() -tooling_conf.set('abs_top_builddir', meson.build_root()) -tooling_conf.set('abs_top_srcdir', meson.source_root()) - -foreach file : tooling_files - configure_file( - input: file, - output: '@BASENAME@', - configuration: tooling_conf, - ) -endforeach - - # print configuration summary driver_summary = { -- 2.35.1