Re: [libvirt] [PATCH] conf: fix use after free in virChrdevOpen

On 05/22/2013 04:44 PM, Eric Blake wrote:

On 05/22/2013 05:37 AM, Ján Tomko wrote:

...

Don't free the stream on error if we've successfully added it to the hash table, since it will be freed by virChrdevHashEntryFree callback.

Preserve the error message before calling virStreamFree, since it resets the error.

Reported by Sergey Fionov on libvir-list. --- src/conf/virchrdev.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-)

ACK. It might help if you track down which commit introduced the problem and mention that in the commit message.

Thanks, I've amended the commit message and pushed it. Jan