On Tue, Jan 21, 2020 at 13:34:27 +0000, Daniel Berrange wrote:
On Fri, Jan 10, 2020 at 04:42:41PM +0100, Peter Krempa wrote:
Add a command which allows to read a secret value from terminal. 'secret-passwd' is chosen as a name as the password has limitations as passwords do have (printable, terminated by newline which is not contained in the value). This makes it way more user-friendly to use the secret driver with virsh when setting a value.
In a later patch you already extend secret-set-value to have a new "--filename PATH" arg. I think we should do the same for interactive usage, eg
$ virsh secret-set-value --prompt
or --interactive / -i
Hmm, yeah. Originally I've added this one first for simplicity and then dealt with the --filename thing, but you are right that this is the better option.