Re: [libvirt] [PATCH v2 2/2] qemu: Default to virtio-net where available
On Thu, Sep 03, 2015 at 11:12:23AM +0200, Andrea Bolognani wrote:
On Thu, 2015-09-03 at 09:53 +0100, Daniel P. Berrange wrote:
> I think we should just do nothing. If people/apps care about optimal
> defaults, nothing libvirt changes will make them happy. Apps need to
> be just using libosinfo to get the sensible defaults on a per OS
> basis.
This is not about optimal defaults though, it's about being
able to install the OS at all without having to explicitly
specify that you want to use virtio:
$ sudo virt-install \
[...] \
--os-variant=rhel7.0 \
--network network=default
ERROR internal error: early end of file from monitor:
possible problem: 2015-09-03T09:00:42.154356Z qemu-kvm:
-device rtl8139,netdev=hostnet0,id=net0,mac=52:54:00:d4:d8:8f,\
bus=pci.0,addr=0x1: 'rtl8139' is not a valid device model name
This happens because we assume rtl8139 will be available, but
that's not the case eg. on RHEL ppc64.
Right, but changing upstream to default to virtio, just because RHEL
downstream disabled other devices is not right.
Either upstream will need to dynamically change if it finds the device
not available, or downstream RHEL libvirt should have a downstream only
patch to workaround the RHEL QEMU PPC64 changes.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|