Re: [libvirt] [PATCH] testutils: Explicitly name virTestCompare*() arguments
On 2/20/19 2:37 AM, Michal Privoznik wrote:
On 2/19/19 9:19 PM, John Ferlan wrote:
> Assuming extraction (sigh) of the VIR_AUTOFREE,
>
> Reviewed-by: John Ferlan<jferlan(a)redhat.com>
>
While I'd definitely want this to be split into two patches if it was
fixing something under src/, but this is under tests/ and therefore I
did not bother. The reason for splitting a patch into smaller
semanticaly divided patches is to help distro maintainers to ease
backports. I don't think they will need to backport this patch, nor will
they want only a part of it.
Just going with precedent I've seen for other patches regardless of
where they're found in the tree. Personally, I'm fine with doing it all
at once. But I think perhaps some one should take the time to write
down what the "house rules" are on the hacking page. Makes it easier
that way.
Go ahead with one patch -
John
But I can do the split if you still want me to.
I'm postponing the push for now.
Thanks,
Michal