Re: [libvirt] [PATCH v10 15/19] backup: qemu: Add directory for tracking checkpoints
On Wed, Jul 24, 2019 at 12:56:05AM -0500, Eric Blake wrote:
This is similar to the existing directory for snapshots; the domain
will save one xml file per checkpoint, for reloading on the next
libvirtd restart. Fortunately, since checkpoints mandate RNG
validation, we are assured that the checkpoint name will be usable as
a file name (no abuse of '../escape' as a checkpoint name, for
example).
but see my question earlier.
I would rather have an explicit check in the code forbidding
'/' even if validation is also checking this, but that's not
dealt with in this patch anyway.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|