On Thu, May 16, 2024 at 10:24:22AM +0200, Andrea Bolognani wrote:
As a general rule, we use defines for features that can only be enabled on a subset of the platforms that we target, and we don't offer fine-grained control over every single possible meson configuration knob at the RPM level.
In the case of ssh-proxy, we are enabling it everywhere already, so having a define for it is unnecessary.
The only reason for a conditional would be if some older distro lacks support for this SSH proxy'ing feature. Assuming RHEL-9 / Ubuntu 22.04 have it, then this is indeed redundant
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- libvirt.spec.in | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|