On Tue, May 29, 2018 at 10:24:46AM +0200, Michal Privoznik wrote:
Now that virCryptoGenerateRandom() is plain wrapper over
virRandomBytes() we can drop it in favour of the latter.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/libvirt_private.syms | 1 -
src/qemu/qemu_domain.c | 5 +++--
src/util/vircrypto.c | 18 ------------------
src/util/vircrypto.h | 3 ---
tests/qemuxml2argvmock.c | 7 -------
5 files changed, 3 insertions(+), 31 deletions(-)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 8d381ee11b..18c0c3e954 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -1649,7 +1649,6 @@ virConfWriteMem;
# util/vircrypto.h
virCryptoEncryptData;
-virCryptoGenerateRandom;
virCryptoHashBuf;
virCryptoHashString;
virCryptoHaveCipher;
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 2d13a03344..e49398432f 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -51,6 +51,7 @@
#include "viratomic.h"
#include "virprocess.h"
#include "vircrypto.h"
+#include "virrandom.h"
You can also remove this include from vircrypto.c
ACK with that changed and also ACK to patch 9.