Re: [libvirt] [PATCH 1/4] vcpupin: improve vcpupin definition of virsh vcpupin

Unfortunately this does not appear to build cleanly, due to const-cast warnings: make[3]: Entering directory `/home/berrange/src/virt/libvirt/tools' CC virsh-virsh.o cc1: warnings being treated as errors virsh.c: In function 'cmdVcpupin': virsh.c:3064:9: error: assignment discards qualifiers from pointer target type virsh.c:3084:9: error: passing argument 1 of 'virParseNumber' from incompatible pointer type ../src/util/util.h:172:5: note: expected 'const char **' but argument is of type 'char **' virsh.c:3092:9: error: passing argument 1 of 'virSkipSpaces' from incompatible pointer type ../src/util/util.h:171:6: note: expected 'const char **' but argument is of type 'char **' virsh.c:3106:13: error: passing argument 1 of 'virSkipSpaces' from incompatible pointer type ../src/util/util.h:171:6: note: expected 'const char **' but argument is of type 'char **' virsh.c:3108:13: error: passing argument 1 of 'virParseNumber' from incompatible pointer type ../src/util/util.h:172:5: note: expected 'const char **' but argument is of type 'char **' virsh.c:3119:13: error: passing argument 1 of 'virSkipSpaces' from incompatible pointer type ../src/util/util.h:171:6: note: expected 'const char **' but argument is of type 'char **' virsh.c:3124:13: error: passing argument 1 of 'virSkipSpaces' from incompatible pointer type ../src/util/util.h:171:6: note: expected 'const char **' but argument is of type 'char **' make[3]: *** [virsh-virsh.o] Error 1 A reminder to everyone who commits. It is essential to run configure + build with --enable-compile-warnings=error before pushing patches