Re: [libvirt] [PATCH 1/2] qemu: Separate image metadata removal into a function

On Tue, Nov 19, 2019 at 10:14:08 +0100, Michal Privoznik wrote:

There are four places where we remove image XATTRs and in all of them we have the same for() loop with the same body. Move it into a separate function because I'm about to introduce fifth place where the same needs to be done.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- src/qemu/qemu_block.c | 25 ++++++++++++++++++++++ src/qemu/qemu_block.h | 6 ++++++ src/qemu/qemu_blockjob.c | 45 ++++------------------------------------ 3 files changed, 35 insertions(+), 41 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>