Re: [libvirt] [PATCH] Generate HACKING from docs/hacking.html.in

On 11/12/2010 10:15 AM, Matthias Bolte wrote: Patch 1 review: Using "e.g." in every <li> of this bullet-list seems redundant; but cleaning that up can be a separate patch (in fact, I've already written the patch, as part of the VIR_RESIZE series that I'm trying to revive, but haven't pushed it to the list yet until yours is in, so I'll get more merge conflicts if you change wording now :) Should errno be surrounded in <code>, since it is a variable name? I like this change... and this is already wrong, since it lacks a return type. Let's adjust it to match the same style: static int myInternalFunc() { there are several code analysis tools that work better if all function implementation names start on column 0, with return type and other decorations on the previous line. Even though we don't yet have a consistent style throughout libvirt, we might as well have a single style in the hacking guide. ACK, either as-is, or if you want to make a few tweaks per my above comments. Either way, it's a good cleanup and documentation-only, so I don't need to see a v2 before you push this patch. -- Eric Blake eblake(a)redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org