"Daniel P. Berrange" <berrange@redhat.com> wrote on 03/25/2010 07:04:32 AM:

> [image removed]

>
> Re: [libvirt] [PATCH v3 09/14] Add XML parser extensions to the
> domain XML processing

>
> Daniel P. Berrange

>
> to:

>
> Stefan Berger

>
> 03/25/2010 07:05 AM

>
> Cc:

>
> libvir-list, Gerhard Stenzel

>
> Please respond to "Daniel P. Berrange"

>
> On Tue, Mar 23, 2010 at 10:54:15AM -0400, stefanb@us.ibm.com wrote:
> > This patch extends the domain XML processing to parse the top level
> > referenced filter along with potentially provided parameters and also
> > converts the internal data back into XML representation.
> >
> > Signed-off-by: Stefan Berger <stefanb@us.ibm.com>
> > Signed-off-by: Gerhard Stenzel <gerhard.stenzel@de.ibm.com>
> >
> > ---
> >  src/conf/domain_conf.c |   39 +++++++++++++++++++++++++++++++++++++++
> >  src/conf/domain_conf.h |    4 ++++
> >  2 files changed, 43 insertions(+)
>
> ACK, looks good, though it would be good to also update the docs/
> schemas/domain.rng
> schema with the new element info. That's fine as a followup patch - no need to
> respin the whole series.


We will follow up on this in a separate patch.

Regards,
   Stefan


>
> Regards,
> Daniel
> --
> |: Red Hat, Engineering, London    -o-  
http://people.redhat.com/berrange/:|
> |:
http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org:|
> |:
http://autobuild.org        -o-         http://search.cpan.org/~danberr/:|
> |: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|