[libvirt] [PATCHv5 9/9] conf: reject multiple panic devices of same model
Only one panic device per model is allowed.
---
v5: minor code fixes
src/conf/domain_conf.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index ef322f5..c30f420 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -3747,6 +3747,28 @@ virDomainDefRejectDuplicateControllers(virDomainDefPtr def)
return ret;
}
+static int
+virDomainDefRejectDuplicatePanics(virDomainDefPtr def)
+{
+ bool exists[VIR_DOMAIN_PANIC_MODEL_LAST];
+ size_t i;
+
+ for (i = 0; i < VIR_DOMAIN_PANIC_MODEL_LAST; i++)
+ exists[i] = false;
+
+ for (i = 0; i < def->npanics; i++) {
+ virDomainPanicModel model = def->panics[i]->model;
+ if (exists[model]) {
+ virReportError(VIR_ERR_XML_ERROR,
+ _("Multiple panic devices with model
'%s'"),
+ virDomainPanicModelTypeToString(model));
+ return -1;
+ }
+ exists[model] = true;
+ }
+
+ return 0;
+}
/**
* virDomainDefMetadataSanitize:
@@ -3976,6 +3998,9 @@ virDomainDefPostParseInternal(virDomainDefPtr def,
if (virDomainDefRejectDuplicateControllers(def) < 0)
return -1;
+ if (virDomainDefRejectDuplicatePanics(def) < 0)
+ return -1;
+
/* verify settings of guest timers */
for (i = 0; i < def->clock.ntimers; i++) {
virDomainTimerDefPtr timer = def->clock.timers[i];
--
1.8.3.1