Re: [libvirt] [dbus RFC 11/11] main: add support for all libvirt drivers

On Tue, Jan 23, 2018 at 10:12:26AM +0000, Daniel P. Berrange wrote: > On Mon, Jan 22, 2018 at 06:16:09PM +0100, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com&gt; > > --- > > src/main.c | 26 ++++++++++++++++++++++---- > > 1 file changed, 22 insertions(+), 4 deletions(-) > > > > diff --git a/src/main.c b/src/main.c > > index 14c7c18..6421919 100644 > > --- a/src/main.c > > +++ b/src/main.c > > @@ -85,13 +85,31 @@ struct virtDBusDriver { > > }; > > > > static const struct virtDBusDriver sessionDrivers[] = { > > - { "qemu:///session", "/org/libvirt/qemu" }, > > - { "test:///default", "/org/libvirt/test" }, > > + { "qemu:///session", "/org/libvirt/qemu" }, > > + { "test:///default", "/org/libvirt/test" }, > > + { "uml:///session", "/org/libvirt/uml" }, > > + { "vbox:///session", "/org/libvirt/vbox" }, > > + { "vmwarefusion:///session", "/org/libvirt/vmwarefusion" }, > > + { "vmwareplayer:///session", "/org/libvirt/vmwareplayer" }, > > + { "vmwarews:///session", "/org/libvirt/vmwarews" }, > > }; > > > > static const struct virtDBusDriver systemDrivers[] = { > > - { "qemu:///system", "/org/libvirt/qemu" }, > > - { "test:///default", "/org/libvirt/test" }, > > + { "XenApi://localhost/", "/org/libvirt/XenApi" }, > > Hmm, lowercase 'xenapi' would match all other paths, but uppercase > matches the URI scheme. There is another "issue" with the naming, best practices for D-Bus object names is to have the first letter uppercase, e.g. "/org/libvirt/Qemu", but that feels strange.