On Thu, Dec 22, 2016 at 07:22 PM +0100, Andrea Bolognani <abologna@redhat.com> wrote:
[Added Roman to CC]
On Tue, 2016-12-20 at 11:54 +0100, Michal Privoznik wrote:
This patch series adds the functionality to detect a misconfiguration between disk bus type and disk address type for disks that are using the address type virDomainDeviceDriveAddress. It also adds a test for it.
A check for other bus types may be needed. This may require a driver specific function, as it is already implemented in virDomainDeviceDefPostParse(), for example.
Changelog: - v1 -> v2: + Use full enumeration of the bus types + Add warning for unexpected bus type
Marc Hartmayer (2): conf: Detect misconfiguration between disk bus and disk address tests: Add tests for disk configuration validation
ACKed and pushed.
This seems to have broken the bhyve driver:
$ VIR_TEST_DEBUG=1 ./tests/bhyvexml2argvtest TEST: bhyvexml2argvtest 1) BHYVE XML-2-ARGV base ... libvirt: Domain Config error : unsupported configuration: Invalid address type 'pci' for the disk 'hda' with the bus type 'sata' FAILED ...
-- Andrea Bolognani / Red Hat / Virtualization
Ooops, sry for that :/ As far as I've read, Roman has already created a new way for the bhyve SATA address allocation in libvirt (thread mid:20170105144634.28675-1-bogorodskiy@gmail.com) -- Beste Grüße / Kind regards Marc Hartmayer IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294