Re: [libvirt PATCH 4/4] gitlab-ci: Introduce a new test 'integration' pipeline stage
On Wed, Mar 02, 2022 at 05:22:07PM +0100, Erik Skultety wrote:
> that can be used by the local sysadmin to define such a policy.
true, but I suppose from upstream's perspective it can already be handled using
gitlab tags only, so it feels redundant to handle the same on multiple places.
Right, but you have to keep in mind that the person working on the
project might not be the same one managing the machines, and that the
latter shouldn't have to rely on the former getting the configuration
just right to ensure that their desired usage policy is enforced.
Configuration mistakes on the project's side should result in failed
jobs, not usage policy violations.
> I guess this is already sort of already implicitly implemented
due to
> the fact that a job will fail if the corresponding VM template does
> not exist...
Yes, it'll throw an error, possibly an ugly exception (I hope not) when this
happens.
Perhaps all we really need to do is to make sure that a nice,
explanatory error message is produced in this scenario then :)
--
Andrea Bolognani / Red Hat / Virtualization