Re: [libvirt] [PATCH RFCv2 4/5] libssh2_transport: Use libssh2 driver code in remote driver

On 04.01.2012 00:47, Peter Krempa wrote: > - if (verr && verr->code == VIR_ERR_NO_SUPPORT) { > - /* Missing RPC - old server - ignore */ > - virResetLastError(); > - return 0; > + if ((verr = virGetLastError())) { > + if (verr->code == VIR_ERR_NO_SUPPORT) { > + /* Missing RPC - old server - ignore */ > + virResetLastError(); > + return 0; > + } > + > + if (verr->code == VIR_ERR_LIBSSH_REMOTE_COMMAND) { > + virResetLastError(); > + remoteError(VIR_ERR_LIBSSH_REMOTE_COMMAND, "%s", > + _("Remote daemon is not running or remote command has failed")); > + } > } > return -1; > } Related to 1st patch in the set: Some users might be using ssh-agent, however, want to select different auth mechanisms. I'd suggest to allow users to select which auth mechanism they want to use. If we don't parse ssh configs, we should let user to choose if he wants keyboard-interactive or ssh-agent or ...; Otherwise we end up trying to sign in with keys provided by ssh-agent which doesn't really must have the right ones. For example, /me uses ssh-agent for git+ssh://libvirt.org but use public keys for other machines and even keyboard-interactive :)