Re: [libvirt] [PATCH v2 0/4] Allow creation of vHBA by parent_wwnn/wwpn or fabric_name

On Wed, Jan 04, 2017 at 05:48:34PM -0500, John Ferlan wrote: > v1: > http://www.redhat.com/archives/libvir-list/2016-November/msg00866.html > > Based on ACKs some of the v1 changes were pushed to make this series > appear shorter. > > Changes since v1 > > - Patch 1 (formerly patch 4) > > Rather than separate XML elements, use the existing <parent> and just > make attributes for wwnn, wwpn, and fabric_wwn. The parent element can > now be string text or empty. > > Added checked for if either wwnn/wwpn provided, then the other is too. > > - Patch 2 (formerly patch 5) > > No changes, but no formal ACK either > > - Patch 3 (formerly patch 10) > > Rather than READ_WWN macro across two functions, I created a helper > function to read and compare the various wwn values (wwnn, wwpn, and > fabric_wwn). > > John Ferlan (4): > nodedev: Add the ability to create vHBA by parent wwnn/wwpn or > fabric_wwn > conf: Add more fchost search fields for storage pool vHBA creation > util: Introduce virGetFCHostNameByFabricWWN > iscsi: Add parent wwnn/wwpn or fabric capability for createVport > > docs/schemas/basictypes.rng | 15 ++++ > docs/schemas/nodedev.rng | 24 +++++- > src/conf/node_device_conf.c | 126 > +++++++++++++++++++++++++++++++ > src/conf/node_device_conf.h | 14 ++++ > src/conf/storage_conf.c | 21 +++++- > src/conf/storage_conf.h | 3 + > src/libvirt_private.syms | 3 + > src/node_device/node_device_driver.c | 13 ++++ > src/storage/storage_backend_scsi.c | 21 +++++- > src/util/virutil.c | 141 > ++++++++++++++++++++++++++--------- > src/util/virutil.h | 4 + > 11 files changed, 346 insertions(+), 39 deletions(-) > ACK series