On Fri, 2018-01-05 at 15:41 -0500, John Ferlan wrote:
src/util/virhostcpu.c | 141 ++++++++++++++++++++++---------------------------- 1 file changed, 62 insertions(+), 79 deletions(-)
Couple of nits... see below
Reviewed-by: John Ferlan <jferlan@redhat.com>
diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c index c485a9721..d47062013 100644 --- a/src/util/virhostcpu.c +++ b/src/util/virhostcpu.c @@ -508,6 +508,65 @@ virHostCPUHasValidSubcoreConfiguration(int threads_per_subcore) return ret; }
Two blank lines between functions...
+static int +virHostCPUParseFrequencyString(const char *str, + const char *prefix, + unsigned int *mhz) +{
I guess Bjoern tried to be consistent with the rest of the file, which mostly uses a single line to separate functions. But I'm perfectly fine using two lines as well, so I'll change it before pushing unless someone feels very strongly against it. -- Andrea Bolognani / Red Hat / Virtualization