On 12/18/2013 09:30 PM, Eric Blake wrote:
Rather than reverting this patch, I'd prefer to fix the string creation
to use the intended order:
diff --git i/src/storage/storage_backend_gluster.c
w/src/storage/storage_backend_gluster.c
index 622526b..aab70ba 100644
--- i/src/storage/storage_backend_gluster.c
+++ w/src/storage/storage_backend_gluster.c
@@ -227,7 +227,7 @@
virStorageBackendGlusterRefreshVol(virStorageBackendGlusterStatePtr state,
goto cleanup;
tmp = state->uri->path;
- if (virAsprintf(&vol->key, "%s%s", state->uri->path, name)
< 0) {
+ if (virAsprintf(&state->uri->path, "%s%s", vol->key, name)
< 0) {
Except that's not right, either. I'll post what I actually tested in a
separate thread.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library
http://libvirt.org