Re: [libvirt] [PATCH v4 00/15] parallels: rewrite driver with parallels SDK

On 12/01/14 19:49, Maxim Nestratov wrote: > 01.12.2014 18:38, Dmitry Guryanov пишет: >> This patch series replaces all code, which used prlctl command >> to interact with parallels cloud server with calls to >> parallels sdk functions. >> >> The model of this driver remain almost the same - in creates a >> list of virDomainObj objects on connect and then functions, which >> returns different information get info from this list. >> >> Changes in v2: >> * Rebase to latest libvirt sources >> * Use only "parallels" prefix for functions in parallelsDriver, >> >> so that make check will pass >> >> * Update privconn->domains in case we change something from current >> >> connection. >> >> Changes in v3: >> * in parallels: get domain info with SDK: >> replace >> + case VIR_ARCH_X86_64: >> with >> + case PCM_CPU_MODE_64: >> >> Changes in v4: >> * handle onReboot, onPoweroff and onCrash properly >> * handle disks cache mode >> * don't set net interface name if virDomainNetDef.ifname is NULL >> * improve error handling >> >> Alexander Burluka (4): >> parallels: get domain info with SDK >> parallels: handle events from parallels server >> parallels: added function virDomainIsActive() >> parallels: Add domainCreateWithFlags() function. >> >> Dmitry Guryanov (11): >> parallels: move IS_CT macro to parallels_utils.h >> parallels: move parallelsDomNotFoundError to parallels_utils.h >> parallels: reimplement functions, which change domain state >> parallels: rewrite parallelsApplyConfig with SDK >> parallels: create VMs and containers with sdk >> parallels: refactor parallelsDomainDefineXML >> parallels: add cdroms support >> parallels: implement domainUndefine and domainUndefineFlags >> parallels: return PRL_RESULT from waitJob and getJobResult >> parallels: fix getJobResultHelper >> parallels: report proper error in Create/Destroy/Suspend e.t.c. >> >> src/parallels/parallels_driver.c | 2456 >> >> +++++++----------------------------- >> >> src/parallels/parallels_sdk.c | 2544 >> >> +++++++++++++++++++++++++++++++++++++- >> >> src/parallels/parallels_sdk.h | 25 + >> src/parallels/parallels_utils.h | 11 + >> 4 files changed, 3033 insertions(+), 2003 deletions(-) > > Series looks good to me as a first step to switch to SDK. I'll take over from here. I need to install the SDK first so I can make sure that everything compiles before pushing. I'll hope I get to push this this week.

Peter