[libvirt] [PATCH 4/7] conf: Introduce new attribute for device address format

Monday, 27 February 2012

* src/conf/domain_conf.h: Add new member "target" to struct
  _virDomainDeviceDriveAddress.

* src/conf/domain_conf.c: Parse and format "target"

* Lots of tests (.xml) in tests/domainsnapshotxml2xmlout,
  tests/qemuxml2argvdata, tests/qemuxml2xmloutdata, and
  tests/vmx2xmldata/ are modified for newly introduced
  attribute "target" for address of "drive" type.
---
 docs/formatdomain.html.in                          |   12 ++++++++++--
 docs/schemas/domaincommon.rng                      |   10 ++++++++++
 src/conf/domain_conf.c                             |   17 +++++++++++++----
 src/conf/domain_conf.h                             |    1 +
 tests/domainsnapshotxml2xmlout/disk_snapshot.xml   |   12 ++++++------
 tests/domainsnapshotxml2xmlout/full_domain.xml     |    2 +-
 tests/domainsnapshotxml2xmlout/metadata.xml        |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-bios.xml       |    2 +-
 .../qemuxml2argvdata/qemuxml2argv-blkdeviotune.xml |    4 ++--
 .../qemuxml2argv-blkiotune-device.xml              |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-blkiotune.xml  |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-boot-cdrom.xml |    2 +-
 .../qemuxml2argv-boot-complex-bootindex.xml        |   10 +++++-----
 .../qemuxml2argvdata/qemuxml2argv-boot-complex.xml |   10 +++++-----
 .../qemuxml2argvdata/qemuxml2argv-boot-floppy.xml  |    4 ++--
 ...uxml2argv-boot-menu-disable-drive-bootindex.xml |    2 +-
 .../qemuxml2argv-boot-menu-disable-drive.xml       |    2 +-
 .../qemuxml2argv-boot-menu-disable.xml             |    2 +-
 .../qemuxml2argv-boot-menu-enable.xml              |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-boot-multi.xml |    2 +-
 .../qemuxml2argvdata/qemuxml2argv-boot-network.xml |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-boot-order.xml |    6 +++---
 tests/qemuxml2argvdata/qemuxml2argv-bootloader.xml |    2 +-
 .../qemuxml2argv-channel-guestfwd.xml              |    2 +-
 .../qemuxml2argv-channel-spicevmc-old.xml          |    2 +-
 .../qemuxml2argv-channel-spicevmc.xml              |    2 +-
 .../qemuxml2argv-channel-virtio-auto.xml           |    2 +-
 .../qemuxml2argv-channel-virtio.xml                |    2 +-
 .../qemuxml2argvdata/qemuxml2argv-clock-france.xml |    2 +-
 .../qemuxml2argv-clock-localtime.xml               |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-clock-utc.xml  |    2 +-
 .../qemuxml2argv-clock-variable.xml                |    2 +-
 .../qemuxml2argv-console-compat-auto.xml           |    2 +-
 .../qemuxml2argv-console-compat-chardev.xml        |    2 +-
 .../qemuxml2argv-console-compat.xml                |    2 +-
 .../qemuxml2argv-console-virtio-many.xml           |    2 +-
 .../qemuxml2argv-console-virtio.xml                |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-cputune.xml    |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-disk-aio.xml   |    4 ++--
 .../qemuxml2argv-disk-cdrom-empty.xml              |    4 ++--
 tests/qemuxml2argvdata/qemuxml2argv-disk-cdrom.xml |    4 ++--
 .../qemuxml2argv-disk-copy_on_read.xml             |    2 +-
 .../qemuxml2argv-disk-drive-boot-cdrom.xml         |    4 ++--
 .../qemuxml2argv-disk-drive-boot-disk.xml          |    4 ++--
 .../qemuxml2argv-disk-drive-cache-directsync.xml   |    4 ++--
 .../qemuxml2argv-disk-drive-cache-unsafe.xml       |    4 ++--
 .../qemuxml2argv-disk-drive-cache-v1-none.xml      |    4 ++--
 .../qemuxml2argv-disk-drive-cache-v1-wb.xml        |    4 ++--
 .../qemuxml2argv-disk-drive-cache-v1-wt.xml        |    4 ++--
 .../qemuxml2argv-disk-drive-cache-v2-none.xml      |    4 ++--
 .../qemuxml2argv-disk-drive-cache-v2-wb.xml        |    4 ++--
 .../qemuxml2argv-disk-drive-cache-v2-wt.xml        |    4 ++--
 ...muxml2argv-disk-drive-error-policy-enospace.xml |    4 ++--
 .../qemuxml2argv-disk-drive-error-policy-stop.xml  |    4 ++--
 ...rgv-disk-drive-error-policy-wreport-rignore.xml |    4 ++--
 .../qemuxml2argv-disk-drive-fat.xml                |    2 +-
 .../qemuxml2argv-disk-drive-fmt-qcow.xml           |    4 ++--
 .../qemuxml2argv-disk-drive-network-nbd.xml        |    2 +-
 .../qemuxml2argv-disk-drive-network-rbd-auth.xml   |    2 +-
 ...emuxml2argv-disk-drive-network-rbd-ceph-env.xml |    2 +-
 .../qemuxml2argv-disk-drive-network-rbd.xml        |    2 +-
 .../qemuxml2argv-disk-drive-network-sheepdog.xml   |    2 +-
 .../qemuxml2argv-disk-drive-no-boot.xml            |    6 +++---
 .../qemuxml2argv-disk-drive-readonly-disk.xml      |    4 ++--
 .../qemuxml2argv-disk-drive-readonly-no-device.xml |    4 ++--
 .../qemuxml2argv-disk-drive-shared.xml             |    4 ++--
 .../qemuxml2argvdata/qemuxml2argv-disk-floppy.xml  |    6 +++---
 .../qemuxml2argv-disk-ioeventfd.xml                |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-disk-many.xml  |    8 ++++----
 .../qemuxml2argv-disk-sata-device.xml              |    2 +-
 .../qemuxml2argv-disk-scsi-device.xml              |    6 +++---
 .../qemuxml2argv-disk-snapshot.xml                 |    6 +++---
 .../qemuxml2argv-disk-transient.xml                |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-disk-usb.xml   |    2 +-
 .../qemuxml2argvdata/qemuxml2argv-disk-virtio.xml  |    4 ++--
 .../qemuxml2argvdata/qemuxml2argv-disk-xenvbd.xml  |    4 ++--
 tests/qemuxml2argvdata/qemuxml2argv-event_idx.xml  |    2 +-
 .../qemuxml2argv-floppy-drive-fat.xml              |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-fs9p.xml       |    2 +-
 .../qemuxml2argv-graphics-listen-network.xml       |    2 +-
 .../qemuxml2argv-graphics-listen-network2.xml      |    2 +-
 .../qemuxml2argv-graphics-sdl-fullscreen.xml       |    2 +-
 .../qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml |    2 +-
 .../qemuxml2argv-graphics-spice-compression.xml    |    2 +-
 .../qemuxml2argv-graphics-spice-qxl-vga.xml        |    2 +-
 .../qemuxml2argv-graphics-spice-timeout.xml        |    2 +-
 .../qemuxml2argv-graphics-spice.xml                |    2 +-
 .../qemuxml2argv-graphics-vnc-sasl.xml             |    2 +-
 .../qemuxml2argv-graphics-vnc-socket.xml           |    2 +-
 .../qemuxml2argv-graphics-vnc-tls.xml              |    2 +-
 .../qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml |    2 +-
 .../qemuxml2argv-hostdev-pci-address.xml           |    2 +-
 .../qemuxml2argv-hostdev-usb-address.xml           |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-hugepages.xml  |    2 +-
 .../qemuxml2argv-input-usbmouse-addr.xml           |    2 +-
 .../qemuxml2argv-input-usbmouse.xml                |    2 +-
 .../qemuxml2argv-input-usbtablet.xml               |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml  |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-lease.xml      |    4 ++--
 .../qemuxml2argv-machine-aliases1.xml              |    2 +-
 .../qemuxml2argv-machine-aliases2.xml              |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-memtune.xml    |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-metadata.xml   |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-migrate.xml    |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-minimal.xml    |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-misc-acpi.xml  |    2 +-
 .../qemuxml2argv-misc-no-reboot.xml                |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-misc-uuid.xml  |    2 +-
 .../qemuxml2argv-multifunction-pci-device.xml      |    2 +-
 .../qemuxml2argv-net-bandwidth.xml                 |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-net-client.xml |    2 +-
 .../qemuxml2argv-net-eth-ifname.xml                |    2 +-
 .../qemuxml2argv-net-eth-names.xml                 |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-net-eth.xml    |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-net-mcast.xml  |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-net-server.xml |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-net-user.xml   |    2 +-
 .../qemuxml2argv-net-virtio-device.xml             |    2 +-
 .../qemuxml2argv-net-virtio-network-portgroup.xml  |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-net-virtio.xml |    2 +-
 .../qemuxml2argv-nographics-vga.xml                |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-nographics.xml |    2 +-
 .../qemuxml2argv-numatune-memory.xml               |    2 +-
 .../qemuxml2argv-parallel-tcp-chardev.xml          |    2 +-
 .../qemuxml2argvdata/qemuxml2argv-parallel-tcp.xml |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-pci-rom.xml    |    2 +-
 .../qemuxml2argv-qemu-ns-no-env.xml                |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-qemu-ns.xml    |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-restore-v1.xml |    2 +-
 .../qemuxml2argv-restore-v2-fd.xml                 |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-restore-v2.xml |    2 +-
 .../qemuxml2argv-seclabel-dynamic-baselabel.xml    |    2 +-
 .../qemuxml2argv-seclabel-dynamic-override.xml     |    4 ++--
 .../qemuxml2argv-seclabel-dynamic.xml              |    2 +-
 .../qemuxml2argv-seclabel-none.xml                 |    2 +-
 .../qemuxml2argv-seclabel-static-relabel.xml       |    2 +-
 .../qemuxml2argv-seclabel-static.xml               |    2 +-
 .../qemuxml2argv-serial-dev-chardev.xml            |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-serial-dev.xml |    2 +-
 .../qemuxml2argv-serial-file-chardev.xml           |    2 +-
 .../qemuxml2argvdata/qemuxml2argv-serial-file.xml  |    2 +-
 .../qemuxml2argv-serial-many-chardev.xml           |    2 +-
 .../qemuxml2argvdata/qemuxml2argv-serial-many.xml  |    2 +-
 .../qemuxml2argv-serial-pty-chardev.xml            |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-serial-pty.xml |    2 +-
 .../qemuxml2argv-serial-target-port-auto.xml       |    2 +-
 .../qemuxml2argv-serial-tcp-chardev.xml            |    2 +-
 .../qemuxml2argv-serial-tcp-telnet-chardev.xml     |    2 +-
 .../qemuxml2argv-serial-tcp-telnet.xml             |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp.xml |    2 +-
 .../qemuxml2argv-serial-udp-chardev.xml            |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-serial-udp.xml |    2 +-
 .../qemuxml2argv-serial-unix-chardev.xml           |    2 +-
 .../qemuxml2argvdata/qemuxml2argv-serial-unix.xml  |    2 +-
 .../qemuxml2argv-serial-vc-chardev.xml             |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-serial-vc.xml  |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-smbios.xml     |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-smp.xml        |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-sound.xml      |    2 +-
 tests/qemuxml2argvdata/qemuxml2argv-watchdog.xml   |    2 +-
 .../qemuxml2xmlout-balloon-device-auto.xml         |    2 +-
 .../qemuxml2xmlout-channel-virtio-auto.xml         |    2 +-
 .../qemuxml2xmlout-console-compat-auto.xml         |    2 +-
 .../qemuxml2xmlout-console-virtio.xml              |    2 +-
 .../qemuxml2xmlout-disk-cdrom-empty.xml            |    4 ++--
 .../qemuxml2xmlout-disk-scsi-device-auto.xml       |    4 ++--
 .../qemuxml2xmlout-graphics-listen-network2.xml    |    2 +-
 .../qemuxml2xmlout-graphics-spice-timeout.xml      |    2 +-
 .../qemuxml2xmloutdata/qemuxml2xmlout-metadata.xml |    2 +-
 .../qemuxml2xmlout-serial-target-port-auto.xml     |    2 +-
 tests/vmx2xmldata/vmx2xml-case-insensitive-1.xml   |    2 +-
 tests/vmx2xmldata/vmx2xml-case-insensitive-2.xml   |    2 +-
 tests/vmx2xmldata/vmx2xml-cdrom-ide-device.xml     |    2 +-
 tests/vmx2xmldata/vmx2xml-cdrom-ide-file.xml       |    2 +-
 tests/vmx2xmldata/vmx2xml-cdrom-scsi-device.xml    |    2 +-
 tests/vmx2xmldata/vmx2xml-cdrom-scsi-file.xml      |    2 +-
 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-1.xml    |    2 +-
 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-2.xml    |   12 ++++++------
 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-3.xml    |    6 +++---
 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-4.xml    |    2 +-
 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-5.xml    |    4 ++--
 tests/vmx2xmldata/vmx2xml-esx-in-the-wild-6.xml    |    4 ++--
 tests/vmx2xmldata/vmx2xml-floppy-device.xml        |    2 +-
 tests/vmx2xmldata/vmx2xml-floppy-file.xml          |    2 +-
 tests/vmx2xmldata/vmx2xml-gsx-in-the-wild-1.xml    |    2 +-
 tests/vmx2xmldata/vmx2xml-gsx-in-the-wild-2.xml    |    2 +-
 tests/vmx2xmldata/vmx2xml-gsx-in-the-wild-3.xml    |    2 +-
 tests/vmx2xmldata/vmx2xml-gsx-in-the-wild-4.xml    |    2 +-
 tests/vmx2xmldata/vmx2xml-harddisk-ide-file.xml    |    2 +-
 tests/vmx2xmldata/vmx2xml-harddisk-scsi-file.xml   |    2 +-
 tests/vmx2xmldata/vmx2xml-scsi-driver.xml          |    8 ++++----
 tests/vmx2xmldata/vmx2xml-scsi-writethrough.xml    |    2 +-
 tests/vmx2xmldata/vmx2xml-ws-in-the-wild-1.xml     |    4 ++--
 tests/vmx2xmldata/vmx2xml-ws-in-the-wild-2.xml     |    4 ++--
 194 files changed, 292 insertions(+), 264 deletions(-)

diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 29497a0..6fcca94 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -1094,6 +1094,12 @@
       &lt;target dev='hdc' bus='ide'/&gt;
       &lt;readonly/&gt;
     &lt;/disk&gt;
+    &lt;disk type='block' device='lun'&gt;
+      &lt;driver name='qemu' type='raw'/&gt;
+      &lt;source dev='/dev/sda'/&lt;
+      &lt;target dev='sda' bus='scsi'/&lt;
+      &lt;address type='drive' controller='0' bus='0'
target='3' unit='0'/&lt;
+    &lt;/disk&gt;
   &lt;/devices&gt;
   ...</pre>
 
@@ -1401,8 +1407,9 @@
         Multifunction defaults to 'off'; any other value requires
         QEMU 0.1.3 and <span class="since">libvirt 0.9.7</span>. 
For a
         "drive" controller, additional attributes
-        <code>controller</code>, <code>bus</code>,
-        and <code>unit</code> are available, each defaulting to 0.
+        <code>controller</code>, <code>bus</code>,
<code>target</code>
+        (<span class="since">libvirt 0.9.11</span>), and
<code>unit</code>
+        are available, each defaulting to 0.
       </dd>
       <dt><code>auth</code></dt>
       <dd>If present, the <code>auth</code> element provides the
@@ -1592,6 +1599,7 @@
       <dd>Drive addresses have the following additional
         attributes: <code>controller</code> (a 2-digit controller
         number), <code>bus</code> (a 2-digit bus number),
+        <code>target</code> (a 2-digit bus number),
         and <code>unit</code> (a 2-digit unit number on the bus).
       </dd>
       <dt><code>type='virtio-serial'</code></dt>
diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index 724d7d0..3908733 100644
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas/domaincommon.rng
@@ -2460,6 +2460,11 @@
       </attribute>
     </optional>
     <optional>
+      <attribute name="target">
+        <ref name="driveTarget"/>
+      </attribute>
+    </optional>
+    <optional>
       <attribute name="unit">
         <ref name="driveUnit"/>
       </attribute>
@@ -3147,6 +3152,11 @@
       <param name="pattern">[0-9]{1,2}</param>
     </data>
   </define>
+  <define name="driveTarget">
+    <data type="string">
+      <param name="pattern">[0-9]{1,2}</param>
+    </data>
+  </define>
   <define name="driveUnit">
     <data type="string">
       <param name="pattern">[0-9]{1,2}</param>
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 2b68841..f9654f1 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -1913,7 +1913,7 @@ void virDomainDefClearDeviceAliases(virDomainDefPtr def)
 
 
 /* Generate a string representation of a device address
- * @param address Device address to stringify
+ * @info address Device address to stringify
  */
 static int ATTRIBUTE_NONNULL(2)
 virDomainDeviceInfoFormat(virBufferPtr buf,
@@ -1975,9 +1975,10 @@ virDomainDeviceInfoFormat(virBufferPtr buf,
         break;
 
     case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_DRIVE:
-        virBufferAsprintf(buf, " controller='%d' bus='%d'
unit='%d'",
+        virBufferAsprintf(buf, " controller='%d' bus='%d'
target='%d' unit='%d'",
                           info->addr.drive.controller,
                           info->addr.drive.bus,
+                          info->addr.drive.target,
                           info->addr.drive.unit);
         break;
 
@@ -2016,7 +2017,6 @@ virDomainDeviceInfoFormat(virBufferPtr buf,
     return 0;
 }
 
-
 static int
 virDomainDevicePCIAddressParseXML(xmlNodePtr node,
                                   virDomainDevicePCIAddressPtr addr)
@@ -2090,13 +2090,14 @@ static int
 virDomainDeviceDriveAddressParseXML(xmlNodePtr node,
                                     virDomainDeviceDriveAddressPtr addr)
 {
-    char *bus, *unit, *controller;
+    char *bus, *unit, *controller, *target;
     int ret = -1;
 
     memset(addr, 0, sizeof(*addr));
 
     controller = virXMLPropString(node, "controller");
     bus = virXMLPropString(node, "bus");
+    target = virXMLPropString(node, "target");
     unit = virXMLPropString(node, "unit");
 
     if (controller &&
@@ -2113,6 +2114,13 @@ virDomainDeviceDriveAddressParseXML(xmlNodePtr node,
         goto cleanup;
     }
 
+    if (target &&
+        virStrToLong_ui(target, NULL, 10, &addr->target) < 0) {
+        virDomainReportError(VIR_ERR_INTERNAL_ERROR, "%s",
+                             _("Cannot parse <address> 'target'
attribute"));
+        goto cleanup;
+    }
+
     if (unit &&
         virStrToLong_ui(unit, NULL, 10, &addr->unit) < 0) {
         virDomainReportError(VIR_ERR_INTERNAL_ERROR, "%s",
@@ -2125,6 +2133,7 @@ virDomainDeviceDriveAddressParseXML(xmlNodePtr node,
 cleanup:
     VIR_FREE(controller);
     VIR_FREE(bus);
+    VIR_FREE(target);
     VIR_FREE(unit);
     return ret;
 }
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index fed7cc3..596be4d 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -106,6 +106,7 @@ typedef virDomainDeviceDriveAddress *virDomainDeviceDriveAddressPtr;
 struct _virDomainDeviceDriveAddress {
     unsigned int controller;
     unsigned int bus;
+    unsigned int target;
     unsigned int unit;
 };
 
diff --git a/tests/domainsnapshotxml2xmlout/disk_snapshot.xml
b/tests/domainsnapshotxml2xmlout/disk_snapshot.xml
index 91dba79..c57f38f 100644
--- a/tests/domainsnapshotxml2xmlout/disk_snapshot.xml
+++ b/tests/domainsnapshotxml2xmlout/disk_snapshot.xml
@@ -42,32 +42,32 @@
       <disk type='block' device='disk'>
         <source dev='/dev/HostVG/QEMUGuest1'/>
         <target dev='hda' bus='ide'/>
-        <address type='drive' controller='0' bus='0'
unit='0'/>
+        <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
       </disk>
       <disk type='block' device='disk'>
         <source dev='/dev/HostVG/QEMUGuest2'/>
         <target dev='hdb' bus='ide'/>
-        <address type='drive' controller='0' bus='1'
unit='0'/>
+        <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
       </disk>
       <disk type='block' device='disk'>
         <source dev='/dev/HostVG/QEMUGuest3'/>
         <target dev='hdc' bus='ide'/>
-        <address type='drive' controller='0' bus='2'
unit='0'/>
+        <address type='drive' controller='0' bus='2'
target='0' unit='0'/>
       </disk>
       <disk type='block' device='disk'>
         <source dev='/dev/HostVG/QEMUGuest4'/>
         <target dev='hdd' bus='ide'/>
-        <address type='drive' controller='0' bus='3'
unit='0'/>
+        <address type='drive' controller='0' bus='3'
target='0' unit='0'/>
       </disk>
       <disk type='block' device='disk'>
         <source dev='/dev/HostVG/QEMUGuest5'/>
         <target dev='hde' bus='ide'/>
-        <address type='drive' controller='0' bus='4'
unit='0'/>
+        <address type='drive' controller='0' bus='4'
target='0' unit='0'/>
       </disk>
       <disk type='block' device='disk'>
         <source dev='/dev/HostVG/QEMUGuest6'/>
         <target dev='hdf' bus='ide'/>
-        <address type='drive' controller='0' bus='5'
unit='0'/>
+        <address type='drive' controller='0' bus='5'
target='0' unit='0'/>
       </disk>
       <controller type='usb' index='0'/>
       <controller type='ide' index='0'/>
diff --git a/tests/domainsnapshotxml2xmlout/full_domain.xml
b/tests/domainsnapshotxml2xmlout/full_domain.xml
index 3063910..a55f353 100644
--- a/tests/domainsnapshotxml2xmlout/full_domain.xml
+++ b/tests/domainsnapshotxml2xmlout/full_domain.xml
@@ -25,7 +25,7 @@
       <disk type='block' device='disk'>
         <source dev='/dev/HostVG/QEMUGuest1'/>
         <target dev='hda' bus='ide'/>
-        <address type='drive' controller='0' bus='0'
unit='0'/>
+        <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
       </disk>
       <controller type='usb' index='0'/>
       <controller type='ide' index='0'/>
diff --git a/tests/domainsnapshotxml2xmlout/metadata.xml
b/tests/domainsnapshotxml2xmlout/metadata.xml
index 9553b17..263cbba 100644
--- a/tests/domainsnapshotxml2xmlout/metadata.xml
+++ b/tests/domainsnapshotxml2xmlout/metadata.xml
@@ -29,7 +29,7 @@
       <disk type='block' device='disk'>
         <source dev='/dev/HostVG/QEMUGuest1'/>
         <target dev='hda' bus='ide'/>
-        <address type='drive' controller='0' bus='0'
unit='0'/>
+        <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
       </disk>
       <controller type='usb' index='0'/>
       <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-bios.xml
b/tests/qemuxml2argvdata/qemuxml2argv-bios.xml
index 9b71164..9312bee 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-bios.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-bios.xml
@@ -19,7 +19,7 @@
    <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-blkdeviotune.xml
b/tests/qemuxml2argvdata/qemuxml2argv-blkdeviotune.xml
index 6b4da65..828d199 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-blkdeviotune.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-blkdeviotune.xml
@@ -22,7 +22,7 @@
         <total_bytes_sec>5000</total_bytes_sec>
         <total_iops_sec>6000</total_iops_sec>
       </iotune>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='disk'>
       <driver name='qemu' type='qcow2' cache='none'/>
@@ -33,7 +33,7 @@
         <write_bytes_sec>5000</write_bytes_sec>
         <total_iops_sec>7000</total_iops_sec>
       </iotune>
-      <address type='drive' controller='0' bus='0'
unit='1'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='1'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-blkiotune-device.xml
b/tests/qemuxml2argvdata/qemuxml2argv-blkiotune-device.xml
index 6c2d282..97a8183 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-blkiotune-device.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-blkiotune-device.xml
@@ -28,7 +28,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-blkiotune.xml
b/tests/qemuxml2argvdata/qemuxml2argv-blkiotune.xml
index ae7133f..5be9b37 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-blkiotune.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-blkiotune.xml
@@ -20,7 +20,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-boot-cdrom.xml
b/tests/qemuxml2argvdata/qemuxml2argv-boot-cdrom.xml
index 183894b..44a30de 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-boot-cdrom.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-boot-cdrom.xml
@@ -18,7 +18,7 @@
       <source dev='/dev/cdrom'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-boot-complex-bootindex.xml
b/tests/qemuxml2argvdata/qemuxml2argv-boot-complex-bootindex.xml
index 860f52e..8ee42e7 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-boot-complex-bootindex.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-boot-complex-bootindex.xml
@@ -24,12 +24,12 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/hdb'/>
       <target dev='hdb' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='1'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='1'/>
     </disk>
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/hda'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='disk'>
       <source file='/tmp/vda.img'/>
@@ -38,17 +38,17 @@
     <disk type='block' device='cdrom'>
       <source dev='/dev/HostVG/hdc'/>
       <target dev='hdc' bus='ide'/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='floppy'>
       <source dev='/dev/fd1'/>
       <target dev='fdb' bus='fdc'/>
-      <address type='drive' controller='0' bus='0'
unit='1'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='1'/>
     </disk>
     <disk type='block' device='floppy'>
       <source dev='/dev/fd0'/>
       <target dev='fda' bus='fdc'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='fdc' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-boot-complex.xml
b/tests/qemuxml2argvdata/qemuxml2argv-boot-complex.xml
index 860f52e..8ee42e7 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-boot-complex.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-boot-complex.xml
@@ -24,12 +24,12 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/hdb'/>
       <target dev='hdb' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='1'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='1'/>
     </disk>
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/hda'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='disk'>
       <source file='/tmp/vda.img'/>
@@ -38,17 +38,17 @@
     <disk type='block' device='cdrom'>
       <source dev='/dev/HostVG/hdc'/>
       <target dev='hdc' bus='ide'/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='floppy'>
       <source dev='/dev/fd1'/>
       <target dev='fdb' bus='fdc'/>
-      <address type='drive' controller='0' bus='0'
unit='1'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='1'/>
     </disk>
     <disk type='block' device='floppy'>
       <source dev='/dev/fd0'/>
       <target dev='fda' bus='fdc'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='fdc' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-boot-floppy.xml
b/tests/qemuxml2argvdata/qemuxml2argv-boot-floppy.xml
index ff20736..f55ee2c 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-boot-floppy.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-boot-floppy.xml
@@ -17,12 +17,12 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='floppy'>
       <source file='/tmp/firmware.img'/>
       <target dev='fda' bus='fdc'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='fdc' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-boot-menu-disable-drive-bootindex.xml
b/tests/qemuxml2argvdata/qemuxml2argv-boot-menu-disable-drive-bootindex.xml
index 66a64df..28b1b68 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-boot-menu-disable-drive-bootindex.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-boot-menu-disable-drive-bootindex.xml
@@ -19,7 +19,7 @@
       <source dev='/dev/cdrom'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-boot-menu-disable-drive.xml
b/tests/qemuxml2argvdata/qemuxml2argv-boot-menu-disable-drive.xml
index 66a64df..28b1b68 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-boot-menu-disable-drive.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-boot-menu-disable-drive.xml
@@ -19,7 +19,7 @@
       <source dev='/dev/cdrom'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-boot-menu-disable.xml
b/tests/qemuxml2argvdata/qemuxml2argv-boot-menu-disable.xml
index 66a64df..28b1b68 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-boot-menu-disable.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-boot-menu-disable.xml
@@ -19,7 +19,7 @@
       <source dev='/dev/cdrom'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-boot-menu-enable.xml
b/tests/qemuxml2argvdata/qemuxml2argv-boot-menu-enable.xml
index d92f681..7847a99 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-boot-menu-enable.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-boot-menu-enable.xml
@@ -19,7 +19,7 @@
       <source dev='/dev/cdrom'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-boot-multi.xml
b/tests/qemuxml2argvdata/qemuxml2argv-boot-multi.xml
index 09556da..85e6d91 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-boot-multi.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-boot-multi.xml
@@ -22,7 +22,7 @@
       <source dev='/dev/cdrom'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-boot-network.xml
b/tests/qemuxml2argvdata/qemuxml2argv-boot-network.xml
index aec0796..38f88aa 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-boot-network.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-boot-network.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-boot-order.xml
b/tests/qemuxml2argvdata/qemuxml2argv-boot-order.xml
index f46ef5c..69ba3c0 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-boot-order.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-boot-order.xml
@@ -16,14 +16,14 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='cdrom'>
       <source file='/root/boot.iso'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
       <boot order='1'/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <disk type='network' device='disk'>
       <driver name='qemu' type='raw'/>
@@ -38,7 +38,7 @@
       <source file='/dev/null'/>
       <target dev='fdb' bus='fdc'/>
       <boot order='4'/>
-      <address type='drive' controller='0' bus='0'
unit='1'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='1'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-bootloader.xml
b/tests/qemuxml2argvdata/qemuxml2argv-bootloader.xml
index 332e6b6..be07426 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-bootloader.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-bootloader.xml
@@ -18,7 +18,7 @@
       <source dev='/dev/cdrom'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-channel-guestfwd.xml
b/tests/qemuxml2argvdata/qemuxml2argv-channel-guestfwd.xml
index 1016ead..7b776c5 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-channel-guestfwd.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-channel-guestfwd.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-channel-spicevmc-old.xml
b/tests/qemuxml2argvdata/qemuxml2argv-channel-spicevmc-old.xml
index 9b53469..6505b55 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-channel-spicevmc-old.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-channel-spicevmc-old.xml
@@ -16,7 +16,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-channel-spicevmc.xml
b/tests/qemuxml2argvdata/qemuxml2argv-channel-spicevmc.xml
index 9b53469..6505b55 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-channel-spicevmc.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-channel-spicevmc.xml
@@ -16,7 +16,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-channel-virtio-auto.xml
b/tests/qemuxml2argvdata/qemuxml2argv-channel-virtio-auto.xml
index dd3bd9d..73f2ce3 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-channel-virtio-auto.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-channel-virtio-auto.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-channel-virtio.xml
b/tests/qemuxml2argvdata/qemuxml2argv-channel-virtio.xml
index e13f8b9..9b9403e 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-channel-virtio.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-channel-virtio.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-clock-france.xml
b/tests/qemuxml2argvdata/qemuxml2argv-clock-france.xml
index 60560ee..aa1b3c2 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-clock-france.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-clock-france.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-clock-localtime.xml
b/tests/qemuxml2argvdata/qemuxml2argv-clock-localtime.xml
index 958b3d2..ff36120 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-clock-localtime.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-clock-localtime.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-clock-utc.xml
b/tests/qemuxml2argvdata/qemuxml2argv-clock-utc.xml
index 317f793..c0975ac 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-clock-utc.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-clock-utc.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-clock-variable.xml
b/tests/qemuxml2argvdata/qemuxml2argv-clock-variable.xml
index eea6ce4..510ccb1 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-clock-variable.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-clock-variable.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-console-compat-auto.xml
b/tests/qemuxml2argvdata/qemuxml2argv-console-compat-auto.xml
index 7fb2ff9..00532dc 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-console-compat-auto.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-console-compat-auto.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-console-compat-chardev.xml
b/tests/qemuxml2argvdata/qemuxml2argv-console-compat-chardev.xml
index 1a7899a..4f7dafb 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-console-compat-chardev.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-console-compat-chardev.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-console-compat.xml
b/tests/qemuxml2argvdata/qemuxml2argv-console-compat.xml
index f579b11..081cd8a 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-console-compat.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-console-compat.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-console-virtio-many.xml
b/tests/qemuxml2argvdata/qemuxml2argv-console-virtio-many.xml
index 71b7fbe..84971b6 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-console-virtio-many.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-console-virtio-many.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-console-virtio.xml
b/tests/qemuxml2argvdata/qemuxml2argv-console-virtio.xml
index 8311e59..ec73348 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-console-virtio.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-console-virtio.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-cputune.xml
b/tests/qemuxml2argvdata/qemuxml2argv-cputune.xml
index b892320..b3192c7 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-cputune.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-cputune.xml
@@ -24,7 +24,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-aio.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-aio.xml
index 12b114f..f1c9a42 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-aio.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-aio.xml
@@ -18,14 +18,14 @@
       <driver name='qemu' type='qcow2' cache='none'
io='native'/>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='cdrom'>
       <driver name='qemu' type='raw' io='threads'/>
       <source dev='/dev/HostVG/QEMUGuest2'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-cdrom-empty.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-cdrom-empty.xml
index 565b8e2..8fdcb1d 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-cdrom-empty.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-cdrom-empty.xml
@@ -17,12 +17,12 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='cdrom'>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-cdrom.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-cdrom.xml
index cea3f4a..ab09ed6 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-cdrom.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-cdrom.xml
@@ -17,13 +17,13 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='cdrom'>
       <source file='/root/boot.iso'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-copy_on_read.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-copy_on_read.xml
index a94623a..fb0bf2b 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-copy_on_read.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-copy_on_read.xml
@@ -25,7 +25,7 @@
       <source file='/var/lib/libvirt/Fedora-14-x86_64-Live-KDE.iso'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <interface type='user'>
       <mac address='52:54:00:e5:48:58'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-boot-cdrom.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-boot-cdrom.xml
index a018655..dda54f8 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-boot-cdrom.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-boot-cdrom.xml
@@ -17,12 +17,12 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='cdrom'>
       <source dev='/dev/HostVG/QEMUGuest2'/>
       <target dev='hdc' bus='ide'/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-boot-disk.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-boot-disk.xml
index ba27ec6..cff1a42 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-boot-disk.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-boot-disk.xml
@@ -17,12 +17,12 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='cdrom'>
       <source dev='/dev/HostVG/QEMUGuest2'/>
       <target dev='hdc' bus='ide'/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-directsync.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-directsync.xml
index 1996223..d32d569 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-directsync.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-directsync.xml
@@ -18,14 +18,14 @@
       <driver name='qemu' type='qcow2'
cache='directsync'/>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='cdrom'>
       <driver name='qemu' type='raw'/>
       <source dev='/dev/HostVG/QEMUGuest2'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-unsafe.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-unsafe.xml
index 562ff0a..f2362af 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-unsafe.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-unsafe.xml
@@ -18,14 +18,14 @@
       <driver name='qemu' type='qcow2' cache='unsafe'/>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='cdrom'>
       <driver name='qemu' type='raw'/>
       <source dev='/dev/HostVG/QEMUGuest2'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-none.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-none.xml
index 2d954de..078e2e7 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-none.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-none.xml
@@ -18,14 +18,14 @@
       <driver name='qemu' type='qcow2' cache='none'/>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='cdrom'>
       <driver name='qemu' type='raw'/>
       <source dev='/dev/HostVG/QEMUGuest2'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-wb.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-wb.xml
index adb243d..1e575ed 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-wb.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-wb.xml
@@ -18,14 +18,14 @@
       <driver name='qemu' type='qcow2' cache='writeback'/>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='cdrom'>
       <driver name='qemu' type='raw'/>
       <source dev='/dev/HostVG/QEMUGuest2'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-wt.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-wt.xml
index 0c50f48..ffa8aba 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-wt.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-wt.xml
@@ -18,14 +18,14 @@
       <driver name='qemu' type='qcow2'
cache='writethrough'/>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='cdrom'>
       <driver name='qemu' type='raw'/>
       <source dev='/dev/HostVG/QEMUGuest2'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-none.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-none.xml
index fcf52a4..4c33b5a 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-none.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-none.xml
@@ -18,14 +18,14 @@
       <driver name='qemu' type='qcow2' cache='none'/>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='cdrom'>
       <driver name='qemu' type='raw'/>
       <source dev='/dev/HostVG/QEMUGuest2'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-wb.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-wb.xml
index 5445be6..cad8257 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-wb.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-wb.xml
@@ -18,14 +18,14 @@
       <driver name='qemu' type='qcow2' cache='writeback'/>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='cdrom'>
       <driver name='qemu' type='raw'/>
       <source dev='/dev/HostVG/QEMUGuest2'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-wt.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-wt.xml
index de543a9..1af9a9f 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-wt.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-wt.xml
@@ -18,14 +18,14 @@
       <driver name='qemu' type='qcow2'
cache='writethrough'/>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='cdrom'>
       <driver name='qemu' type='raw'/>
       <source dev='/dev/HostVG/QEMUGuest2'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-error-policy-enospace.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-error-policy-enospace.xml
index 694c59b..e0182d6 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-error-policy-enospace.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-error-policy-enospace.xml
@@ -18,14 +18,14 @@
       <driver name='qemu' type='qcow2' cache='none'
error_policy='enospace'/>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='cdrom'>
       <driver name='qemu' type='raw'/>
       <source dev='/dev/HostVG/QEMUGuest2'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-error-policy-stop.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-error-policy-stop.xml
index 34fe20f..a1d55f9 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-error-policy-stop.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-error-policy-stop.xml
@@ -18,14 +18,14 @@
       <driver name='qemu' type='qcow2' cache='none'
error_policy='stop'/>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='cdrom'>
       <driver name='qemu' type='raw'/>
       <source dev='/dev/HostVG/QEMUGuest2'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git
a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-error-policy-wreport-rignore.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-error-policy-wreport-rignore.xml
index 80cf5fe..b52d397 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-error-policy-wreport-rignore.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-error-policy-wreport-rignore.xml
@@ -18,14 +18,14 @@
       <driver name='qemu' type='qcow2' cache='none'
error_policy='report' rerror_policy='ignore'/>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='cdrom'>
       <driver name='qemu' type='raw'/>
       <source dev='/dev/HostVG/QEMUGuest2'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-fat.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-fat.xml
index fdf2030..2345bae 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-fat.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-fat.xml
@@ -19,7 +19,7 @@
       <source dir='/var/somefiles'/>
       <target dev='hda' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-fmt-qcow.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-fmt-qcow.xml
index dbece24..599993c 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-fmt-qcow.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-fmt-qcow.xml
@@ -18,14 +18,14 @@
       <driver name='qemu' type='qcow2'/>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='cdrom'>
       <driver name='qemu' type='raw'/>
       <source dev='/dev/HostVG/QEMUGuest2'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-nbd.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-nbd.xml
index 7ba0ab0..a761f6a 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-nbd.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-nbd.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='network' device='disk'>
       <driver name='qemu' type='raw'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd-auth.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd-auth.xml
index a81bf1a..ac6c698 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd-auth.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd-auth.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='network' device='disk'>
       <driver name='qemu' type='raw'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd-ceph-env.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd-ceph-env.xml
index f0bcfd5..8d02517 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd-ceph-env.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd-ceph-env.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='network' device='disk'>
       <driver name='qemu' type='raw'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd.xml
index f0bcfd5..8d02517 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='network' device='disk'>
       <driver name='qemu' type='raw'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-sheepdog.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-sheepdog.xml
index cd0eef4..30e2a75 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-sheepdog.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-sheepdog.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='network' device='disk'>
       <driver name='qemu' type='raw'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-no-boot.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-no-boot.xml
index 88ce751..2ce27a5 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-no-boot.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-no-boot.xml
@@ -19,17 +19,17 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='cdrom'>
       <source dev='/dev/HostVG/QEMUGuest2'/>
       <target dev='hdc' bus='ide'/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='floppy'>
       <source dev='/dev/fd0'/>
       <target dev='fda' bus='fdc'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='fdc' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-readonly-disk.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-readonly-disk.xml
index 380f850..a3ecd9c 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-readonly-disk.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-readonly-disk.xml
@@ -17,13 +17,13 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='cdrom'>
        <source dev='/dev/sr0'/>
        <target dev='hdc' bus='ide'/>
        <readonly/>
-       <address type='drive' controller='0' bus='1'
unit='0'/>
+       <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-readonly-no-device.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-readonly-no-device.xml
index 380f850..a3ecd9c 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-readonly-no-device.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-readonly-no-device.xml
@@ -17,13 +17,13 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='cdrom'>
        <source dev='/dev/sr0'/>
        <target dev='hdc' bus='ide'/>
        <readonly/>
-       <address type='drive' controller='0' bus='1'
unit='0'/>
+       <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared.xml
index c155040..674bbed 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared.xml
@@ -20,14 +20,14 @@
       <target dev='hda' bus='ide'/>
       <shareable/>
       <serial>XYZXYZXYZYXXYZYZYXYZY</serial>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='cdrom'>
       <driver name='qemu' type='raw'/>
       <source dev='/dev/HostVG/QEMUGuest2'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-floppy.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-floppy.xml
index 99adcd4..68e4f06 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-floppy.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-floppy.xml
@@ -17,17 +17,17 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='floppy'>
       <source dev='/dev/fd0'/>
       <target dev='fda' bus='fdc'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='floppy'>
       <source file='/tmp/firmware.img'/>
       <target dev='fdb' bus='fdc'/>
-      <address type='drive' controller='0' bus='0'
unit='1'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='1'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='fdc' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-ioeventfd.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-ioeventfd.xml
index 3bc82cb..00edada 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-ioeventfd.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-ioeventfd.xml
@@ -25,7 +25,7 @@
       <source file='/var/lib/libvirt/Fedora-14-x86_64-Live-KDE.iso'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <interface type='user'>
       <mac address='52:54:00:e5:48:58'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-many.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-many.xml
index c04d6e2..055883a 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-many.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-many.xml
@@ -17,22 +17,22 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest2'/>
       <target dev='hdb' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='1'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='1'/>
     </disk>
     <disk type='file' device='disk'>
       <source file='/tmp/data.img'/>
       <target dev='hdc' bus='ide'/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='disk'>
       <source file='/tmp/logs.img'/>
       <target dev='hdd' bus='ide'/>
-      <address type='drive' controller='0' bus='1'
unit='1'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='1'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-sata-device.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-sata-device.xml
index 81f30e5..3d7fa54 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-sata-device.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-sata-device.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='sda' bus='sata'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='sata' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-scsi-device.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-scsi-device.xml
index 17b59d8..8613b5d 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-scsi-device.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-scsi-device.xml
@@ -17,16 +17,16 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='disk'>
       <source file='/tmp/scsidisk.img'/>
       <target dev='sda' bus='scsi'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
-    <controller type='scsi' index='0'/>
+    <controller type='scsi' index='0' model='lsilogic'/>
     <memballoon model='virtio'/>
   </devices>
 </domain>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-snapshot.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-snapshot.xml
index 2501ac8..0544c05 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-snapshot.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-snapshot.xml
@@ -18,20 +18,20 @@
       <driver name='qemu' type='qcow2' cache='none'/>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='cdrom' snapshot='no'>
       <driver name='qemu' type='raw'/>
       <source dev='/dev/HostVG/QEMUGuest2'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='disk' snapshot='external'>
       <driver name='qemu' type='qcow2' cache='none'/>
       <source dev='/dev/HostVG/QEMUGuest3'/>
       <target dev='hdb' bus='ide'/>
-      <address type='drive' controller='0' bus='2'
unit='0'/>
+      <address type='drive' controller='0' bus='2'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-transient.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-transient.xml
index e5aef0a..aac1b57 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-transient.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-transient.xml
@@ -19,7 +19,7 @@
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
       <transient/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-usb.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-usb.xml
index a8a505d..da238fa 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-usb.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-usb.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='disk'>
       <source file='/tmp/usbdisk.img'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-virtio.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-virtio.xml
index 9a9e966..02d1fd3 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-virtio.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-virtio.xml
@@ -17,13 +17,13 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='cdrom'>
       <source dev='/dev/HostVG/QEMUGuest2'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='disk'>
       <source file='/tmp/data.img'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-xenvbd.xml
b/tests/qemuxml2argvdata/qemuxml2argv-disk-xenvbd.xml
index 4497a04..9606a52 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-disk-xenvbd.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-xenvbd.xml
@@ -17,13 +17,13 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='cdrom'>
       <source dev='/dev/HostVG/QEMUGuest2'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='disk'>
       <source file='/tmp/data.img'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-event_idx.xml
b/tests/qemuxml2argvdata/qemuxml2argv-event_idx.xml
index 6dc346d..a8131b9 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-event_idx.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-event_idx.xml
@@ -27,7 +27,7 @@
       <source file='/var/lib/libvirt/Fedora-14-x86_64-Live-KDE.iso'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='virtio-serial' index='0'>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-floppy-drive-fat.xml
b/tests/qemuxml2argvdata/qemuxml2argv-floppy-drive-fat.xml
index 4d6ebd7..48bcdb7 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-floppy-drive-fat.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-floppy-drive-fat.xml
@@ -19,7 +19,7 @@
       <source dir='/var/somefiles'/>
       <target dev='fda' bus='fdc'/>
       <readonly/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-fs9p.xml
b/tests/qemuxml2argvdata/qemuxml2argv-fs9p.xml
index c187995..2e484cb 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-fs9p.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-fs9p.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-listen-network.xml
b/tests/qemuxml2argvdata/qemuxml2argv-graphics-listen-network.xml
index c341054..36f0e30 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-listen-network.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-listen-network.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-listen-network2.xml
b/tests/qemuxml2argvdata/qemuxml2argv-graphics-listen-network2.xml
index 7985625..3915b82 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-listen-network2.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-listen-network2.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl-fullscreen.xml
b/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl-fullscreen.xml
index 277c1d4..13f7a1f 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl-fullscreen.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl-fullscreen.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml
b/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml
index a5a169a..64cadd8 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-compression.xml
b/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-compression.xml
index 33e2190..ca32267 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-compression.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-compression.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-qxl-vga.xml
b/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-qxl-vga.xml
index ac1a915..8d7eb5c 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-qxl-vga.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-qxl-vga.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-timeout.xml
b/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-timeout.xml
index 6389de5..17fb06c 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-timeout.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-timeout.xml
@@ -50,7 +50,7 @@
       <source file='/var/lib/libvirt/Fedora-14-x86_64-Live-KDE.iso'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'>
       <address type='pci' domain='0x0000' bus='0x00'
slot='0x01' function='0x1'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice.xml
b/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice.xml
index d4e68e4..35cf26d 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.xml
b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.xml
index 339b1fd..cd24468 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-socket.xml
b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-socket.xml
index e3151e5..88b6710 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-socket.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-socket.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-tls.xml
b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-tls.xml
index 339b1fd..cd24468 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-tls.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-tls.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml
b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml
index ad2bfc0..49ad691 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-hostdev-pci-address.xml
b/tests/qemuxml2argvdata/qemuxml2argv-hostdev-pci-address.xml
index a7f0410..2de4c6d 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-hostdev-pci-address.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-hostdev-pci-address.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest2'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-address.xml
b/tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-address.xml
index 80b4771..f6e17ee 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-address.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-address.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-hugepages.xml
b/tests/qemuxml2argvdata/qemuxml2argv-hugepages.xml
index fa0bb96..79fe83d 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-hugepages.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-hugepages.xml
@@ -20,7 +20,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-input-usbmouse-addr.xml
b/tests/qemuxml2argvdata/qemuxml2argv-input-usbmouse-addr.xml
index 858b385..bdf81b2 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-input-usbmouse-addr.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-input-usbmouse-addr.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-input-usbmouse.xml
b/tests/qemuxml2argvdata/qemuxml2argv-input-usbmouse.xml
index cc78f9f..968cc44 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-input-usbmouse.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-input-usbmouse.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-input-usbtablet.xml
b/tests/qemuxml2argvdata/qemuxml2argv-input-usbtablet.xml
index c042ed2..d62e7fd 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-input-usbtablet.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-input-usbtablet.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml
b/tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml
index 0b82b3b..4dc18c5 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-lease.xml
b/tests/qemuxml2argvdata/qemuxml2argv-lease.xml
index b998f62..d42239c 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-lease.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-lease.xml
@@ -17,13 +17,13 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='cdrom'>
       <source file='/root/boot.iso'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-machine-aliases1.xml
b/tests/qemuxml2argvdata/qemuxml2argv-machine-aliases1.xml
index a969f8c..1b5661f 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-machine-aliases1.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-machine-aliases1.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'/>
     <memballoon model='virtio'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-machine-aliases2.xml
b/tests/qemuxml2argvdata/qemuxml2argv-machine-aliases2.xml
index 424179e..c077458 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-machine-aliases2.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-machine-aliases2.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'/>
     <memballoon model='virtio'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-memtune.xml
b/tests/qemuxml2argvdata/qemuxml2argv-memtune.xml
index c81a253..1c31804 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-memtune.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-memtune.xml
@@ -22,7 +22,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-metadata.xml
b/tests/qemuxml2argvdata/qemuxml2argv-metadata.xml
index b0f90dd..1e0b63e 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-metadata.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-metadata.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'/>
     <memballoon model='virtio'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-migrate.xml
b/tests/qemuxml2argvdata/qemuxml2argv-migrate.xml
index e16fce5..7470c8d 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-migrate.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-migrate.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-minimal.xml
b/tests/qemuxml2argvdata/qemuxml2argv-minimal.xml
index d060271..d48d755 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-minimal.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-minimal.xml
@@ -22,7 +22,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-misc-acpi.xml
b/tests/qemuxml2argvdata/qemuxml2argv-misc-acpi.xml
index a4fce92..d43251f 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-misc-acpi.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-misc-acpi.xml
@@ -20,7 +20,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-misc-no-reboot.xml
b/tests/qemuxml2argvdata/qemuxml2argv-misc-no-reboot.xml
index b84a0b4..8c6b861 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-misc-no-reboot.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-misc-no-reboot.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-misc-uuid.xml
b/tests/qemuxml2argvdata/qemuxml2argv-misc-uuid.xml
index a4fce92..d43251f 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-misc-uuid.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-misc-uuid.xml
@@ -20,7 +20,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-multifunction-pci-device.xml
b/tests/qemuxml2argvdata/qemuxml2argv-multifunction-pci-device.xml
index 24b95b8..6568bac 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-multifunction-pci-device.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-multifunction-pci-device.xml
@@ -17,7 +17,7 @@
     <disk type='file' device='disk'>
       <source file='/tmp/scsidisk.img'/>
       <target dev='sda' bus='scsi'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='scsi' index='0'>
       <address type='pci' domain='0x0000' bus='0x00'
slot='0x03' function='0x0' multifunction='off'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-net-bandwidth.xml
b/tests/qemuxml2argvdata/qemuxml2argv-net-bandwidth.xml
index d5e4b9a..4b2e70c 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-net-bandwidth.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-net-bandwidth.xml
@@ -32,7 +32,7 @@
       <source file='/home/zippy/tmp/Fedora-14-x86_64-Live-KDE.iso'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-net-client.xml
b/tests/qemuxml2argvdata/qemuxml2argv-net-client.xml
index b4cca6e..f63d176 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-net-client.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-net-client.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'/>
     <interface type='client'>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-net-eth-ifname.xml
b/tests/qemuxml2argvdata/qemuxml2argv-net-eth-ifname.xml
index bd5a153..aff3f0f 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-net-eth-ifname.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-net-eth-ifname.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-net-eth-names.xml
b/tests/qemuxml2argvdata/qemuxml2argv-net-eth-names.xml
index 74db024..b39f0a2 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-net-eth-names.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-net-eth-names.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'/>
     <interface type='ethernet'>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-net-eth.xml
b/tests/qemuxml2argvdata/qemuxml2argv-net-eth.xml
index 61836be..28758a3 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-net-eth.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-net-eth.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-net-mcast.xml
b/tests/qemuxml2argvdata/qemuxml2argv-net-mcast.xml
index a3929a5..51bc247 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-net-mcast.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-net-mcast.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'/>
     <interface type='mcast'>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-net-server.xml
b/tests/qemuxml2argvdata/qemuxml2argv-net-server.xml
index eca440d..a53d594 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-net-server.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-net-server.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'/>
     <interface type='server'>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-net-user.xml
b/tests/qemuxml2argvdata/qemuxml2argv-net-user.xml
index 4a6f041..32693c5 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-net-user.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-net-user.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-net-virtio-device.xml
b/tests/qemuxml2argvdata/qemuxml2argv-net-virtio-device.xml
index 013c444..149e56c 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-net-virtio-device.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-net-virtio-device.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-net-virtio-network-portgroup.xml
b/tests/qemuxml2argvdata/qemuxml2argv-net-virtio-network-portgroup.xml
index 4a56f59..1f2af97 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-net-virtio-network-portgroup.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-net-virtio-network-portgroup.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-net-virtio.xml
b/tests/qemuxml2argvdata/qemuxml2argv-net-virtio.xml
index f17b5a9..bcd54b3 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-net-virtio.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-net-virtio.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-nographics-vga.xml
b/tests/qemuxml2argvdata/qemuxml2argv-nographics-vga.xml
index e16fce5..7470c8d 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-nographics-vga.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-nographics-vga.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-nographics.xml
b/tests/qemuxml2argvdata/qemuxml2argv-nographics.xml
index 479a1d9..97ff16d 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-nographics.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-nographics.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'/>
     <memballoon model='virtio'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-numatune-memory.xml
b/tests/qemuxml2argvdata/qemuxml2argv-numatune-memory.xml
index 66ec6d0..a717f5c 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-numatune-memory.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-numatune-memory.xml
@@ -23,7 +23,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'/>
     <memballoon model='virtio'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-parallel-tcp-chardev.xml
b/tests/qemuxml2argvdata/qemuxml2argv-parallel-tcp-chardev.xml
index 328f81e..e36f98c 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-parallel-tcp-chardev.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-parallel-tcp-chardev.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'/>
     <parallel type='tcp'>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-parallel-tcp.xml
b/tests/qemuxml2argvdata/qemuxml2argv-parallel-tcp.xml
index 67cf661..33132ae 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-parallel-tcp.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-parallel-tcp.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-pci-rom.xml
b/tests/qemuxml2argvdata/qemuxml2argv-pci-rom.xml
index 51eecbc..327131f 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-pci-rom.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-pci-rom.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest2'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-qemu-ns-no-env.xml
b/tests/qemuxml2argvdata/qemuxml2argv-qemu-ns-no-env.xml
index 9bf8da7..dd128ca 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-qemu-ns-no-env.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-qemu-ns-no-env.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-qemu-ns.xml
b/tests/qemuxml2argvdata/qemuxml2argv-qemu-ns.xml
index c5020a0..19bcd2f 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-qemu-ns.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-qemu-ns.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'/>
   </devices>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-restore-v1.xml
b/tests/qemuxml2argvdata/qemuxml2argv-restore-v1.xml
index 317f793..c0975ac 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-restore-v1.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-restore-v1.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-restore-v2-fd.xml
b/tests/qemuxml2argvdata/qemuxml2argv-restore-v2-fd.xml
index e16fce5..7470c8d 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-restore-v2-fd.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-restore-v2-fd.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-restore-v2.xml
b/tests/qemuxml2argvdata/qemuxml2argv-restore-v2.xml
index e16fce5..7470c8d 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-restore-v2.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-restore-v2.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-seclabel-dynamic-baselabel.xml
b/tests/qemuxml2argvdata/qemuxml2argv-seclabel-dynamic-baselabel.xml
index dfbdf9e..31c3190 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-seclabel-dynamic-baselabel.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-seclabel-dynamic-baselabel.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-seclabel-dynamic-override.xml
b/tests/qemuxml2argvdata/qemuxml2argv-seclabel-dynamic-override.xml
index c34243b..be805fe 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-seclabel-dynamic-override.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-seclabel-dynamic-override.xml
@@ -19,7 +19,7 @@
         <seclabel relabel='no'/>
       </source>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest2'>
@@ -29,7 +29,7 @@
       </source>
       <target dev='hdb' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-seclabel-dynamic.xml
b/tests/qemuxml2argvdata/qemuxml2argv-seclabel-dynamic.xml
index 096c766..e046367 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-seclabel-dynamic.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-seclabel-dynamic.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'/>
     <memballoon model='virtio'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-seclabel-none.xml
b/tests/qemuxml2argvdata/qemuxml2argv-seclabel-none.xml
index b3109ba..6afc3c1 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-seclabel-none.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-seclabel-none.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-seclabel-static-relabel.xml
b/tests/qemuxml2argvdata/qemuxml2argv-seclabel-static-relabel.xml
index 3b2ad04..969fdbd 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-seclabel-static-relabel.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-seclabel-static-relabel.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'/>
     <memballoon model='virtio'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-seclabel-static.xml
b/tests/qemuxml2argvdata/qemuxml2argv-seclabel-static.xml
index 2a8dd5b..9e33a06 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-seclabel-static.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-seclabel-static.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-dev-chardev.xml
b/tests/qemuxml2argvdata/qemuxml2argv-serial-dev-chardev.xml
index b6f9d29..878a0aa 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-serial-dev-chardev.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-serial-dev-chardev.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-dev.xml
b/tests/qemuxml2argvdata/qemuxml2argv-serial-dev.xml
index 56f9006..ac944f3 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-serial-dev.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-serial-dev.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-file-chardev.xml
b/tests/qemuxml2argvdata/qemuxml2argv-serial-file-chardev.xml
index c64da73..afbcd34 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-serial-file-chardev.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-serial-file-chardev.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-file.xml
b/tests/qemuxml2argvdata/qemuxml2argv-serial-file.xml
index 54bfc93..b4d7c52 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-serial-file.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-serial-file.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-many-chardev.xml
b/tests/qemuxml2argvdata/qemuxml2argv-serial-many-chardev.xml
index 29e12be..eaa80b1 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-serial-many-chardev.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-serial-many-chardev.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-many.xml
b/tests/qemuxml2argvdata/qemuxml2argv-serial-many.xml
index 371fc44..c3160e6 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-serial-many.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-serial-many.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-pty-chardev.xml
b/tests/qemuxml2argvdata/qemuxml2argv-serial-pty-chardev.xml
index 17fc702..6da038d 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-serial-pty-chardev.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-serial-pty-chardev.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-pty.xml
b/tests/qemuxml2argvdata/qemuxml2argv-serial-pty.xml
index 7e2ca30..af765ef 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-serial-pty.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-serial-pty.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-target-port-auto.xml
b/tests/qemuxml2argvdata/qemuxml2argv-serial-target-port-auto.xml
index 0f98f51..2e0b2ee 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-serial-target-port-auto.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-serial-target-port-auto.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'/>
     <serial type='pty'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-chardev.xml
b/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-chardev.xml
index 2b1f5d4..76af255 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-chardev.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-chardev.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-telnet-chardev.xml
b/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-telnet-chardev.xml
index 1cebeff..d869348 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-telnet-chardev.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-telnet-chardev.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-telnet.xml
b/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-telnet.xml
index 3b8dca8..1501455 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-telnet.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-telnet.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp.xml
b/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp.xml
index fe19f8b..19496d7 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-udp-chardev.xml
b/tests/qemuxml2argvdata/qemuxml2argv-serial-udp-chardev.xml
index 52ccc94..1ac39ff 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-serial-udp-chardev.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-serial-udp-chardev.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-udp.xml
b/tests/qemuxml2argvdata/qemuxml2argv-serial-udp.xml
index 31c9104..e30d1dc 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-serial-udp.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-serial-udp.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-unix-chardev.xml
b/tests/qemuxml2argvdata/qemuxml2argv-serial-unix-chardev.xml
index e86c1ae..46b0d61 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-serial-unix-chardev.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-serial-unix-chardev.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-unix.xml
b/tests/qemuxml2argvdata/qemuxml2argv-serial-unix.xml
index 053cec1..c928048 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-serial-unix.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-serial-unix.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-vc-chardev.xml
b/tests/qemuxml2argvdata/qemuxml2argv-serial-vc-chardev.xml
index fe1fdad..f6a943c 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-serial-vc-chardev.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-serial-vc-chardev.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'/>
     <serial type='vc'>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-vc.xml
b/tests/qemuxml2argvdata/qemuxml2argv-serial-vc.xml
index c086092..9dfc7c3 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-serial-vc.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-serial-vc.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-smbios.xml
b/tests/qemuxml2argvdata/qemuxml2argv-smbios.xml
index 9f0ea7b..fbffb29 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-smbios.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-smbios.xml
@@ -33,7 +33,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'/>
     <memballoon model='virtio'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-smp.xml
b/tests/qemuxml2argvdata/qemuxml2argv-smp.xml
index 9d0d918..b79ff28 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-smp.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-smp.xml
@@ -20,7 +20,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-sound.xml
b/tests/qemuxml2argvdata/qemuxml2argv-sound.xml
index e5b3f13..921d8ee 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-sound.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-sound.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-watchdog.xml
b/tests/qemuxml2argvdata/qemuxml2argv-watchdog.xml
index e1f6e56..cf427f2 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-watchdog.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-watchdog.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-balloon-device-auto.xml
b/tests/qemuxml2xmloutdata/qemuxml2xmlout-balloon-device-auto.xml
index 317f793..c0975ac 100644
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-balloon-device-auto.xml
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-balloon-device-auto.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-channel-virtio-auto.xml
b/tests/qemuxml2xmloutdata/qemuxml2xmlout-channel-virtio-auto.xml
index 1602b6c..c42d60e 100644
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-channel-virtio-auto.xml
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-channel-virtio-auto.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-console-compat-auto.xml
b/tests/qemuxml2xmloutdata/qemuxml2xmlout-console-compat-auto.xml
index f579b11..081cd8a 100644
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-console-compat-auto.xml
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-console-compat-auto.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-console-virtio.xml
b/tests/qemuxml2xmloutdata/qemuxml2xmlout-console-virtio.xml
index f1f70c7..a7cb73d 100644
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-console-virtio.xml
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-console-virtio.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-cdrom-empty.xml
b/tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-cdrom-empty.xml
index 897b0d2..b394edf 100644
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-cdrom-empty.xml
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-cdrom-empty.xml
@@ -17,13 +17,13 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='cdrom'>
       <target dev='hdc' bus='ide'/>
       <source startupPolicy='optional'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-scsi-device-auto.xml
b/tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-scsi-device-auto.xml
index 17b59d8..c6811bb 100644
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-scsi-device-auto.xml
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-scsi-device-auto.xml
@@ -17,12 +17,12 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='disk'>
       <source file='/tmp/scsidisk.img'/>
       <target dev='sda' bus='scsi'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-listen-network2.xml
b/tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-listen-network2.xml
index 188e14a..76731e0 100644
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-listen-network2.xml
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-listen-network2.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-spice-timeout.xml
b/tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-spice-timeout.xml
index 53298d1..16efb69 100644
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-spice-timeout.xml
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-spice-timeout.xml
@@ -50,7 +50,7 @@
       <source file='/var/lib/libvirt/Fedora-14-x86_64-Live-KDE.iso'/>
       <target dev='hdc' bus='ide'/>
       <readonly/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'>
       <address type='pci' domain='0x0000' bus='0x00'
slot='0x01' function='0x1'/>
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-metadata.xml
b/tests/qemuxml2xmloutdata/qemuxml2xmlout-metadata.xml
index 01b820d..026bcf8 100644
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-metadata.xml
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-metadata.xml
@@ -21,7 +21,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'/>
     <controller type='usb' index='0'/>
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-target-port-auto.xml
b/tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-target-port-auto.xml
index 44472c7..42a8557 100644
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-target-port-auto.xml
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-target-port-auto.xml
@@ -17,7 +17,7 @@
     <disk type='block' device='disk'>
       <source dev='/dev/HostVG/QEMUGuest1'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'/>
     <controller type='usb' index='0'/>
diff --git a/tests/vmx2xmldata/vmx2xml-case-insensitive-1.xml
b/tests/vmx2xmldata/vmx2xml-case-insensitive-1.xml
index ef6edd8..d07d608 100644
--- a/tests/vmx2xmldata/vmx2xml-case-insensitive-1.xml
+++ b/tests/vmx2xmldata/vmx2xml-case-insensitive-1.xml
@@ -18,7 +18,7 @@
     <disk type='file' device='disk'>
       <source file='[datastore] directory/FEDORA11.VMDK'/>
       <target dev='sda' bus='scsi'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='scsi' index='0' model='lsilogic'/>
     <interface type='bridge'>
diff --git a/tests/vmx2xmldata/vmx2xml-case-insensitive-2.xml
b/tests/vmx2xmldata/vmx2xml-case-insensitive-2.xml
index 02771b9..87dd3b8 100644
--- a/tests/vmx2xmldata/vmx2xml-case-insensitive-2.xml
+++ b/tests/vmx2xmldata/vmx2xml-case-insensitive-2.xml
@@ -18,7 +18,7 @@
     <disk type='file' device='disk'>
       <source file='[datastore] directory/fedora11.vmdk'/>
       <target dev='sda' bus='scsi'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='scsi' index='0' model='lsilogic'/>
     <interface type='bridge'>
diff --git a/tests/vmx2xmldata/vmx2xml-cdrom-ide-device.xml
b/tests/vmx2xmldata/vmx2xml-cdrom-ide-device.xml
index e11d2f9..6cbdfe9 100644
--- a/tests/vmx2xmldata/vmx2xml-cdrom-ide-device.xml
+++ b/tests/vmx2xmldata/vmx2xml-cdrom-ide-device.xml
@@ -14,7 +14,7 @@
     <disk type='block' device='cdrom'>
       <source dev='/dev/scd0'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'/>
     <video>
diff --git a/tests/vmx2xmldata/vmx2xml-cdrom-ide-file.xml
b/tests/vmx2xmldata/vmx2xml-cdrom-ide-file.xml
index d1fb690..3bdb70b 100644
--- a/tests/vmx2xmldata/vmx2xml-cdrom-ide-file.xml
+++ b/tests/vmx2xmldata/vmx2xml-cdrom-ide-file.xml
@@ -14,7 +14,7 @@
     <disk type='file' device='cdrom'>
       <source file='[datastore] directory/cdrom.iso'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'/>
     <video>
diff --git a/tests/vmx2xmldata/vmx2xml-cdrom-scsi-device.xml
b/tests/vmx2xmldata/vmx2xml-cdrom-scsi-device.xml
index 7eb3676..00fbf4e 100644
--- a/tests/vmx2xmldata/vmx2xml-cdrom-scsi-device.xml
+++ b/tests/vmx2xmldata/vmx2xml-cdrom-scsi-device.xml
@@ -14,7 +14,7 @@
     <disk type='block' device='cdrom'>
       <source dev='/dev/scd0'/>
       <target dev='sda' bus='scsi'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='scsi' index='0'/>
     <video>
diff --git a/tests/vmx2xmldata/vmx2xml-cdrom-scsi-file.xml
b/tests/vmx2xmldata/vmx2xml-cdrom-scsi-file.xml
index df1e7c4..e8f2e9f 100644
--- a/tests/vmx2xmldata/vmx2xml-cdrom-scsi-file.xml
+++ b/tests/vmx2xmldata/vmx2xml-cdrom-scsi-file.xml
@@ -14,7 +14,7 @@
     <disk type='file' device='cdrom'>
       <source file='[datastore] directory/cdrom.iso'/>
       <target dev='sda' bus='scsi'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='scsi' index='0'/>
     <video>
diff --git a/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-1.xml
b/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-1.xml
index e8f9307..74f49a5 100644
--- a/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-1.xml
+++ b/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-1.xml
@@ -18,7 +18,7 @@
     <disk type='file' device='disk'>
       <source file='[datastore] directory/Fedora11.vmdk'/>
       <target dev='sda' bus='scsi'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='scsi' index='0' model='lsilogic'/>
     <interface type='bridge'>
diff --git a/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-2.xml
b/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-2.xml
index 23fc1f6..2e07963 100644
--- a/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-2.xml
+++ b/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-2.xml
@@ -16,32 +16,32 @@
       <driver cache='writethrough'/>
       <source file='[datastore] directory/Debian1.vmdk'/>
       <target dev='sda' bus='scsi'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='cdrom'>
       <source file='[datastore] directory/Debian1-cdrom.iso'/>
       <target dev='sdp' bus='scsi'/>
-      <address type='drive' controller='1' bus='0'
unit='0'/>
+      <address type='drive' controller='1' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='cdrom'>
       <source file='/vmimages/tools-isoimages/linux.iso'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='block' device='cdrom'>
       <source dev='/dev/scd0'/>
       <target dev='hdb' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='1'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='1'/>
     </disk>
     <disk type='file' device='disk'>
       <source file='[datastore] directory/Debian1-IDE.vmdk'/>
       <target dev='hdd' bus='ide'/>
-      <address type='drive' controller='0' bus='1'
unit='1'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='1'/>
     </disk>
     <disk type='block' device='floppy'>
       <source dev='/dev/fd0'/>
       <target dev='fda' bus='fdc'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='scsi' index='0' model='lsilogic'/>
     <controller type='scsi' index='1' model='buslogic'/>
diff --git a/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-3.xml
b/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-3.xml
index e193fdb..0bc8eed 100644
--- a/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-3.xml
+++ b/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-3.xml
@@ -15,17 +15,17 @@
     <disk type='file' device='disk'>
       <source file='[datastore] directory/Debian2.vmdk'/>
       <target dev='sda' bus='scsi'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='cdrom'>
       <source file='[498076b2-02796c1a-ef5b-000ae484a6a3]
Isos/debian-testing-amd64-netinst.iso'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='floppy'>
       <source file='[498076b2-02796c1a-ef5b-000ae484a6a3]
Debian2/dummy.flp'/>
       <target dev='fdb' bus='fdc'/>
-      <address type='drive' controller='0' bus='0'
unit='1'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='1'/>
     </disk>
     <controller type='scsi' index='0' model='lsilogic'/>
     <controller type='fdc' index='0'/>
diff --git a/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-4.xml
b/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-4.xml
index 2824d66..0844cb2 100644
--- a/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-4.xml
+++ b/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-4.xml
@@ -18,7 +18,7 @@
     <disk type='file' device='disk'>
       <source file='[datastore] directory/virtMonServ1.vmdk'/>
       <target dev='sda' bus='scsi'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='scsi' index='0' model='lsilogic'/>
     <interface type='bridge'>
diff --git a/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-5.xml
b/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-5.xml
index 6f0a9d1..ee23120 100644
--- a/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-5.xml
+++ b/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-5.xml
@@ -22,12 +22,12 @@
     <disk type='file' device='disk'>
       <source file='[datastore] directory/vmtest-000001.vmdk'/>
       <target dev='sda' bus='scsi'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='cdrom'>
       <source file='[4af0231d-1eff559a-6369-0024e84773b6]
isos/CentOS-5.5-x86_64-bin-DVD-1of2.iso'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='scsi' index='0' model='lsilogic'/>
     <controller type='ide' index='0'/>
diff --git a/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-6.xml
b/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-6.xml
index 0c4e4d5..227308b 100644
--- a/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-6.xml
+++ b/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-6.xml
@@ -15,12 +15,12 @@
     <disk type='file' device='disk'>
       <source file='[datastore] directory/el6-test-000001.vmdk'/>
       <target dev='sda' bus='scsi'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='cdrom'>
       <source file='/usr/lib/vmware/isoimages/linux.iso'/>
       <target dev='hdc' bus='ide'/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='scsi' index='0' model='vmpvscsi'/>
     <controller type='ide' index='0'/>
diff --git a/tests/vmx2xmldata/vmx2xml-floppy-device.xml
b/tests/vmx2xmldata/vmx2xml-floppy-device.xml
index 824849a..8aef9c0 100644
--- a/tests/vmx2xmldata/vmx2xml-floppy-device.xml
+++ b/tests/vmx2xmldata/vmx2xml-floppy-device.xml
@@ -14,7 +14,7 @@
     <disk type='block' device='floppy'>
       <source dev='/dev/fd0'/>
       <target dev='fda' bus='fdc'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='fdc' index='0'/>
     <video>
diff --git a/tests/vmx2xmldata/vmx2xml-floppy-file.xml
b/tests/vmx2xmldata/vmx2xml-floppy-file.xml
index 75d0d62..c36e3f0 100644
--- a/tests/vmx2xmldata/vmx2xml-floppy-file.xml
+++ b/tests/vmx2xmldata/vmx2xml-floppy-file.xml
@@ -14,7 +14,7 @@
     <disk type='file' device='floppy'>
       <source file='[datastore] directory/floppy.flp'/>
       <target dev='fda' bus='fdc'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='fdc' index='0'/>
     <video>
diff --git a/tests/vmx2xmldata/vmx2xml-gsx-in-the-wild-1.xml
b/tests/vmx2xmldata/vmx2xml-gsx-in-the-wild-1.xml
index b572ad1..7bc07c5 100644
--- a/tests/vmx2xmldata/vmx2xml-gsx-in-the-wild-1.xml
+++ b/tests/vmx2xmldata/vmx2xml-gsx-in-the-wild-1.xml
@@ -15,7 +15,7 @@
     <disk type='file' device='disk'>
       <source file='[datastore] directory/Debian-System1-0-cl2.vmdk'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'/>
     <interface type='bridge'>
diff --git a/tests/vmx2xmldata/vmx2xml-gsx-in-the-wild-2.xml
b/tests/vmx2xmldata/vmx2xml-gsx-in-the-wild-2.xml
index 180cf68..3297761 100644
--- a/tests/vmx2xmldata/vmx2xml-gsx-in-the-wild-2.xml
+++ b/tests/vmx2xmldata/vmx2xml-gsx-in-the-wild-2.xml
@@ -15,7 +15,7 @@
     <disk type='file' device='disk'>
       <source file='[datastore] directory/Debian-System1-0-cl3.vmdk'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'/>
     <interface type='bridge'>
diff --git a/tests/vmx2xmldata/vmx2xml-gsx-in-the-wild-3.xml
b/tests/vmx2xmldata/vmx2xml-gsx-in-the-wild-3.xml
index 571c83a..78fa951 100644
--- a/tests/vmx2xmldata/vmx2xml-gsx-in-the-wild-3.xml
+++ b/tests/vmx2xmldata/vmx2xml-gsx-in-the-wild-3.xml
@@ -15,7 +15,7 @@
     <disk type='file' device='disk'>
       <source file='[datastore] directory/Debian-System1-0-cl1.vmdk'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'/>
     <interface type='bridge'>
diff --git a/tests/vmx2xmldata/vmx2xml-gsx-in-the-wild-4.xml
b/tests/vmx2xmldata/vmx2xml-gsx-in-the-wild-4.xml
index fc3b966..c25e6e6 100644
--- a/tests/vmx2xmldata/vmx2xml-gsx-in-the-wild-4.xml
+++ b/tests/vmx2xmldata/vmx2xml-gsx-in-the-wild-4.xml
@@ -15,7 +15,7 @@
     <disk type='file' device='disk'>
       <source file='[datastore] directory/Debian-System1-0-cl2.vmdk'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'/>
     <interface type='bridge'>
diff --git a/tests/vmx2xmldata/vmx2xml-harddisk-ide-file.xml
b/tests/vmx2xmldata/vmx2xml-harddisk-ide-file.xml
index 72a5c1f..e2e9bdc 100644
--- a/tests/vmx2xmldata/vmx2xml-harddisk-ide-file.xml
+++ b/tests/vmx2xmldata/vmx2xml-harddisk-ide-file.xml
@@ -14,7 +14,7 @@
     <disk type='file' device='disk'>
       <source file='[datastore] directory/harddisk.vmdk'/>
       <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='ide' index='0'/>
     <video>
diff --git a/tests/vmx2xmldata/vmx2xml-harddisk-scsi-file.xml
b/tests/vmx2xmldata/vmx2xml-harddisk-scsi-file.xml
index 189e72d..4e90388 100644
--- a/tests/vmx2xmldata/vmx2xml-harddisk-scsi-file.xml
+++ b/tests/vmx2xmldata/vmx2xml-harddisk-scsi-file.xml
@@ -14,7 +14,7 @@
     <disk type='file' device='disk'>
       <source file='[datastore] directory/harddisk.vmdk'/>
       <target dev='sda' bus='scsi'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='scsi' index='0'/>
     <video>
diff --git a/tests/vmx2xmldata/vmx2xml-scsi-driver.xml
b/tests/vmx2xmldata/vmx2xml-scsi-driver.xml
index 8fa907b..03a60d0 100644
--- a/tests/vmx2xmldata/vmx2xml-scsi-driver.xml
+++ b/tests/vmx2xmldata/vmx2xml-scsi-driver.xml
@@ -14,22 +14,22 @@
     <disk type='file' device='disk'>
       <source file='[datastore] directory/harddisk1.vmdk'/>
       <target dev='sda' bus='scsi'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='disk'>
       <source file='[datastore] directory/harddisk2.vmdk'/>
       <target dev='sdp' bus='scsi'/>
-      <address type='drive' controller='1' bus='0'
unit='0'/>
+      <address type='drive' controller='1' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='disk'>
       <source file='[datastore] directory/harddisk3.vmdk'/>
       <target dev='sdae' bus='scsi'/>
-      <address type='drive' controller='2' bus='0'
unit='0'/>
+      <address type='drive' controller='2' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='disk'>
       <source file='[datastore] directory/harddisk4.vmdk'/>
       <target dev='sdat' bus='scsi'/>
-      <address type='drive' controller='3' bus='0'
unit='0'/>
+      <address type='drive' controller='3' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='scsi' index='0' model='buslogic'/>
     <controller type='scsi' index='1' model='lsilogic'/>
diff --git a/tests/vmx2xmldata/vmx2xml-scsi-writethrough.xml
b/tests/vmx2xmldata/vmx2xml-scsi-writethrough.xml
index e5b8934..d2b1cb7 100644
--- a/tests/vmx2xmldata/vmx2xml-scsi-writethrough.xml
+++ b/tests/vmx2xmldata/vmx2xml-scsi-writethrough.xml
@@ -15,7 +15,7 @@
       <driver cache='writethrough'/>
       <source file='[datastore] directory/harddisk.vmdk'/>
       <target dev='sda' bus='scsi'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <controller type='scsi' index='0' model='buslogic'/>
     <video>
diff --git a/tests/vmx2xmldata/vmx2xml-ws-in-the-wild-1.xml
b/tests/vmx2xmldata/vmx2xml-ws-in-the-wild-1.xml
index 71bf9e8..4c958ae 100644
--- a/tests/vmx2xmldata/vmx2xml-ws-in-the-wild-1.xml
+++ b/tests/vmx2xmldata/vmx2xml-ws-in-the-wild-1.xml
@@ -15,12 +15,12 @@
     <disk type='file' device='disk'>
       <source file='/data/vmware/disk.vmdk'/>
       <target dev='sda' bus='scsi'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='cdrom'>
       <source file='/usr/lib/vmware/isoimages/linux.iso'/>
       <target dev='hdc' bus='ide'/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='scsi' index='0' model='lsilogic'/>
     <controller type='ide' index='0'/>
diff --git a/tests/vmx2xmldata/vmx2xml-ws-in-the-wild-2.xml
b/tests/vmx2xmldata/vmx2xml-ws-in-the-wild-2.xml
index d310204..0501a45 100644
--- a/tests/vmx2xmldata/vmx2xml-ws-in-the-wild-2.xml
+++ b/tests/vmx2xmldata/vmx2xml-ws-in-the-wild-2.xml
@@ -15,12 +15,12 @@
     <disk type='file' device='disk'>
       <source file='/data/vmware/disk.vmdk'/>
       <target dev='sda' bus='scsi'/>
-      <address type='drive' controller='0' bus='0'
unit='0'/>
+      <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
     </disk>
     <disk type='file' device='cdrom'>
       <source file='/usr/lib/vmware/isoimages/linux.iso'/>
       <target dev='hdc' bus='ide'/>
-      <address type='drive' controller='0' bus='1'
unit='0'/>
+      <address type='drive' controller='0' bus='1'
target='0' unit='0'/>
     </disk>
     <controller type='scsi' index='0' model='lsilogic'/>
     <controller type='ide' index='0'/>
-- 
1.7.7.3


    

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

[libvirt] [PATCH 4/7] conf: Introduce new attribute for device address format