On 8/26/2025 11:14 AM, Peter Krempa wrote:
On Tue, Aug 26, 2025 at 09:33:59 -0500, Praveen K Paladugu wrote:
On 8/25/2025 3:22 PM, Peter Krempa wrote:
On Mon, Aug 25, 2025 at 10:57:52 -0500, Praveen K Paladugu wrote:
Introduce mshv variant in capabilities tests.
Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com> --- .../caps_11.3.0_x86_64+mshv.replies | 46912 ++++++++++++++++ .../caps_11.3.0_x86_64+mshv.xml | 4996 ++ .../qemucaps2xmloutdata/caps.x86_64+mshv.xml | 29 + 3 files changed, 51937 insertions(+) create mode 100644 tests/qemucapabilitiesdata/caps_11.3.0_x86_64+mshv.replies create mode 100644 tests/qemucapabilitiesdata/caps_11.3.0_x86_64+mshv.xml create mode 100644 tests/qemucaps2xmloutdata/caps.x86_64+mshv.xml
Few issues:
1) the test-suite fails after this patch:
$ VIR_TEST_REGENERATE_OUTPUT=1 ./tests/domaincapstest TEST: domaincapstest ............................../home/pipo/libvirt/tests/domaincapsdata/qemu_11.3.0.x86_64+mshv.xml: failed to open: No such file or directory !/home/pipo/libvirt/tests/domaincapsdata/qemu_11.3.0-q35.x86_64+mshv.xml: failed to open: No such file or directory !/home/pipo/libvirt/tests/domaincapsdata/qemu_11.3.0-tcg.x86_64+mshv.xml: failed to open: No such file or directory !....... 40 .................................. 74 FAIL 3 tests failed. Run them using: VIR_TEST_DEBUG=1 VIR_TEST_RANGE=31-33 ./tests/domaincapstest
You seem to have forgotten to commit the two output files.
I didn't notice this failure among the other failures I am seeing with this test locally. I will investigate this further.
Can you elaborate what other failures you are seeing?
I should have clarified this. The test failures I am noticing were not introduced by my code changes. I see these failures even while using latest upstream code (commit: 5b69c37265e4ec876d7a46bd865427388bc37da2): Summary of Failures: 73/300 libvirt:bin / domaincapstest FAIL 1.23s exit status 1 123/300 libvirt:bin / qemufirmwaretest FAIL 0.04s exit status 1 131/300 libvirt:bin / qemuvhostusertest FAIL 0.03s exit status 1 182/300 libvirt:bin / qemuxmlconftest FAIL 7.45s exit status 1 These could be related to missing components or incorrect configuration on my development host (Fedora 42). I didn't investigate these failures, yet. domaincapstest: VIR_TEST_DEBUG=1 VIR_TEST_RANGE=2,4-7,9-10,12,14,16,19-21,23-24,26-27,29-31,34,36-37,39-40,42-43,47,49,51,53-54,56-57,59-60,62-63,65,67-68 /home/prapal/Source/libvirt/build/tests/domaincapstest Most of these tests fail with following signature: 2) qemu_7.2.0.x86_64 ... In '/home/username/Source/libvirt/tests/domaincapsdata/qemu_7.2.0.x86_64.xml': Offset 275 Expect [ <value>efi</value> <] Actual [<] qemufirmwaretest: $ VIR_TEST_DEBUG=1 VIR_TEST_RANGE=19-20,22,24-26 /home/prapal/Source/libvirt/build/tests/qemufirmwaretest TEST: qemufirmwaretest 19) QEMU FW precedence test ... Unexpected path. Expected //share/qemu/firmware/30-edk2-ovmf-4m-qcow2-x64-sb-enrolled.json got /etc/qemu/firmware/59-combined.json FAILED 20) QEMU FW SUPPORTED pc-i440fx-3.1 VIR_ARCH_X86_64 ... Mismatch in supported interfaces. Expected 0x6 got 0x2 FAILED 22) QEMU FW SUPPORTED pc-q35-3.1 VIR_ARCH_X86_64 ... Unexpected FW image: /usr/share/edk2/ovmf/OVMF.secboot.fd NVRAM: <null> Expected: /usr/share/edk2/ovmf/OVMF_CODE_4M.secboot.qcow2 NVRAM: /usr/share/edk2/ovmf/OVMF_VARS_4M.secboot.qcow2 FAILED 24) QEMU FW SUPPORTED microvm VIR_ARCH_X86_64 ... Mismatch in supported interfaces. Expected 0x4 got 0x0 FAILED 25) QEMU FW SUPPORTED virt-3.1 VIR_ARCH_AARCH64 ... Mismatch in supported interfaces. Expected 0x4 got 0x0 FAILED 26) QEMU FW SUPPORTED virt VIR_ARCH_RISCV64 ... Mismatch in supported interfaces. Expected 0x4 got 0x0 FAILED 6 tests failed. Run them using: VIR_TEST_DEBUG=1 VIR_TEST_RANGE=19-20,22,24-26 /home/prapal/Source/libvirt/build/tests/qemufirmwaretest qemuvhostusertest : $ VIR_TEST_DEBUG=1 VIR_TEST_RANGE=2 /home/prapal/Source/libvirt/build/tests/qemuvhostusertest TEST: qemuvhostusertest 2) QEMU vhost-user precedence test ... Unexpected path. Expected //share/qemu/vhost-user/30-gpu.json got /etc/qemu/vhost-user/40-gpu.json FAILED 1 tests failed. Run them using: VIR_TEST_DEBUG=1 VIR_TEST_RANGE=2 /home/prapal/Source/libvirt/build/tests/qemuvhostusertest qemuxmlconftest : VIR_TEST_DEBUG=1 VIR_TEST_RANGE=470,474,498,510,514,518,526,538,542,546,554,558,562,618,620-624,626,628,638,640-644,646,648,650,652,658,660,662,664,666,668,670,672,678,680,682,684-688,690,692-700,702,704,706,708,714,716,718,720,722,724,726,728,730,732,734,736,738,740,742,744,746,748-752,754,756,4226,4228,4234,4236,4566,4568,4862,4864,4866,4868,4880,4884,4914,4918,4950,5066,5068,5070,5072 /home/prapal/Source/libvirt/build/tests/qemuxmlconftest 618) QEMU XML def -> XML firmware-auto-efi.x86_64-latest ... In '/home/prapal/Source/libvirt/tests/qemuxmlconfdata/firmware-auto-efi.x86_64-latest.xml': Offset 303 Expect [firmware> <feature enabled='yes' name='enrolled-keys'/> <feature enabled='yes' name='secure-boot'/> </firmware> <loader readonly='yes' secure='yes' type='pflash' format='raw'>/usr/share/edk2/ovmf/OVMF_CODE.secboot.fd</loader> <nvram template='/usr/share/edk2/ovmf/OVMF_VARS.secboot.fd' templateFormat='raw' format='raw'>/var/lib/libvirt/qemu/nvram/guest_VARS.fd</nvram> <boot dev='hd'/> </os> <features> <acpi/> <smm state='on'] Actual [loader format='raw'/> <boot dev='hd'/> </os> <features> <acpi] ... FAILED
Also note that reviewer bandwidth is limited, so posting patches that you know don't pass the test suite consumes from the available review bandwidth possibly delaying further reviews.
2) the filename of the caps dump is wrong:
diff --git a/tests/qemucapabilitiesdata/caps_11.3.0_x86_64+mshv.replies b/tests/qemucapabilitiesdata/caps_11.3.0_x86_64+mshv.replies
The upcoming qemu version is 10.1 so you can't really have qemu-11.3 at this point.
I noticed some files with caps_10.1.0_x86_64*** versioning. As Qemu version 10.1 was not released, I assumed this is libvirt version.
We do use capabilities from the in-development version to stay on top of upcoming changes. As said if you want to add a capability dump from the current qemu development cycle you need to update it once the appropriate qemu version is released.
The filename is documented in tests/qemucapabilitiesdata/README.rst I've mentioned in my reply to your first posting where you asked about capabilities.
Also the current in-dev libvirt version is 11.7 so using '11.3' by that logic wouldnt' make sense either.
Agreed. My bad, I picked up the version number here prior to rebasing to latest upstream. I will fix this in my next update. -- Regards, Praveen K Paladugu