Re: [libvirt] [PATCHv4 4/4] blkiotune: add qemu support for blkiotune.device_weight
On 11/15/2011 12:22 AM, Hu Tao wrote:
On Mon, Nov 14, 2011 at 09:30:02PM -0700, Eric Blake wrote:
> From: Hu Tao <hutao(a)cn.fujitsu.com>
>
> Implement setting/getting per-device blkio weights in qemu,
> using the cgroups blkio.weight_device tunable.
>
> +/* deviceWeightStr in the form of /device/path,weight,/device/path,weight
> + * for example, /dev/disk/by-path/pci-0000:00:1f.2-scsi-0:0:0:0,800
> + */
> +static int
> +parseBlkioWeightDeviceStr(char *deviceWeightStr,
> + virBlkioDeviceWeightPtr *dw, int *size,
> + virCgroupPtr cgroup)
Does more than the function name says. Would it be better to just do the
parsing here, and set the cgroup values after parsing(see my comment to
patch 3 for filtering out 0-weight when writing to xml):
Either approach works for me (renaming this function more accurately so
that the domain_conf never has 0-weight entries, or going with your
improvements to allow 0-weight entries in the domain_conf def but not
expose them in the XML). I guess whoever reviews this series can cast
the deciding vote on which of the two approaches we commit.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 620 bytes)