Re: [libvirt] [PATCH 2/5] macvtap support for libvirt -- parse new interface XML

Please respond to "Daniel P. Berrange" On Thu, Feb 04, 2010 at 08:02:42AM -0500, Stefan Berger wrote: > This part adds support to domain_conf.{c|h} for parsing the new > interface XML of type 'direct'. > > Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com&gt; > Index: libvirt-macvtap/src/conf/domain_conf.c > =================================================================== > --- libvirt-macvtap.orig/src/conf/domain_conf.c > +++ libvirt-macvtap/src/conf/domain_conf.c > @@ -41,6 +41,7 @@ > #include "c-ctype.h" > #include "logging.h" > #include "network.h" > +#include "macvtap.h" > > #define VIR_FROM_THIS VIR_FROM_DOMAIN > > @@ -140,7 +141,8 @@ VIR_ENUM_IMPL(virDomainNet, VIR_DOMAIN_N > "mcast", > "network", > "bridge", > - "internal") > + "internal", > + "direct") > > VIR_ENUM_IMPL(virDomainChrTarget, VIR_DOMAIN_CHR_TARGET_TYPE_LAST, > "null", > @@ -222,6 +224,12 @@ VIR_ENUM_IMPL(virDomainSeclabel, VIR_DOM > "dynamic", > "static") > > +VIR_ENUM_IMPL(virDomainNetdevMacvtap,

> + MACVTAP_MODE_PRIVATE_STR, > + MACVTAP_MODE_VEPA_STR, > + MACVTAP_MODE_BRIDGE_STR) These strings should really be included here directly - other areas of the code should only ever see the parsed enum integer value, never the string form which is for the XML only.