Re: [libvirt] [PATCH 1/2] conf: add disk cache tuning parameters after qemu
On Mon, Sep 26, 2016 at 11:43:58 +0300, Nikolay Shirokovskiy wrote:
xml example:
<disk ...>
<cachetune writeback='on' direct='off' no_flush='on'/>
Aren't writeback and direct mutually exclusive?
</disk>
What's wrong with
<disk ...>
<driver ... cache=''>?
See https://libvirt.org/formatdomain.html#elementsDisks
This commit message really does not describe your motivation for the
addition.
Parameters semantics match corresponding qemu 'cache.*' parameters.
--
I wonder should we use flush or sync name instead of qemu no_flush?
---
docs/schemas/domaincommon.rng | 22 +++++++++++
src/conf/domain_conf.c | 90 +++++++++++++++++++++++++++++++++++++++++++
src/conf/domain_conf.h | 7 ++++
3 files changed, 119 insertions(+)
Peter