On 10/19/20 3:25 PM, Peter Krempa wrote:
On Mon, Oct 19, 2020 at 13:32:32 -0500, Eric Blake wrote:
On 10/14/20 5:04 AM, Peter Krempa wrote:
Add the monitor code, corresponding generator of properties for NBD and tests validating it against the schema.
Signed-off-by: Peter Krempa <pkrempa@redhat.com> ---
+ + if (virJSONValueObjectCreate(&ret, + "s:type", "nbd", + "s:id", exportid, + "s:node-name", nodename, + "b:writable", writable, + "s:name", exportname, + "S:bitmap", bitmap, + NULL) < 0)
The plan is to upgrade to '*bitmaps':['str'], and retiring '*bitmap':'str' when nbd-server-add goes away: https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg02713.html
so you'll need to tweak this to match.
Uhh, okay, make sure to get that in before the libvirt release so that we don't have a broken libvirt version. I'll fix libvirt ASAP.
v5 of the qemu patch has now landed, with a goal of making soft freeze next week. And this time, I amended that patch to touch deprecated.rst, so this list gets earlier heads-up notification ;) -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org