Re: [PATCH] qemu monitor: Fix incorrect error message condition
Hi Peter
Thank you for the thorough review!
On Tue, Jan 14th, 2025 at 8:29 PM, Peter Krempa <pkrempa(a)redhat.com> wrote:
I'd argue that while the error message is not great there's
no real
reasonable information to return in this case anyways so an error from
the API is a reasonable outcome.
I agree. To address this, I will post a new patch set that improves
error reporting, making it easier for application developers to
understand the issue.
Regarding log spam [1] ... something on your system is repeatedly
querying throttling config of an empty drive which makes no sense. So
perhaps fixing that might make more sense? I'm not even going to
question the need to query throttling info repeatedly.
The application [1] leading to this error message spam on my hypervisor
is a prometheus exporter which does not check the disk type or state
when querying the API. I will address this in the exporter application.
Kind regards,
Fabian Leditzky
[1] https://github.com/Tinkoff/libvirt-exporter