John Ferlan <jferlan@redhat.com> [2018-03-01, 02:22PM -0500]:
On 02/27/2018 04:32 AM, Bjoern Walk wrote:
+ if (VIR_STRDUP(ret->data.s390.reason, reason) < 0) { + virReportOOMError(); + goto error; + }
No need for the OOMError as VIR_STRDUP will splat that for you (the _QUIET one won't).
I can fix that up before pushing though.
I always forget this. Appreciated and thanks a lot. -- IBM Systems Linux on Z & Virtualization Development ------------------------------------------------------------------------ IBM Deutschland Research & Development GmbH Schönaicher Str. 220, 71032 Böblingen Phone: +49 7031 16 1819 ------------------------------------------------------------------------ Vorsitzende des Aufsichtsrats: Martina Koederitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294