On 1/13/20 2:06 PM, Andrea Bolognani wrote:
On Mon, 2020-01-13 at 13:48 +0100, Michal Privoznik wrote:
On 1/13/20 9:30 AM, Thomas Huth wrote:
+++ b/src/conf/domain_conf.c @@ -13428,6 +13428,8 @@ virDomainInputDefParseXML(virDomainXMLOptionPtr xmlopt, def->type == VIR_DOMAIN_INPUT_TYPE_KBD) && (ARCH_IS_X86(dom->os.arch) || dom->os.arch == VIR_ARCH_NONE)) { def->bus = VIR_DOMAIN_INPUT_BUS_PS2; + } else if (ARCH_IS_S390(dom->os.arch)) { + def->bus = VIR_DOMAIN_INPUT_BUS_VIRTIO; } else { def->bus = VIR_DOMAIN_INPUT_BUS_USB; }
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
and pushed.
I don't believe either this or the other patch posted by Thomas should have been pushed during the freeze period. I won't ask you to revert them, but please refrain from pushing further changes unless 6.0.0 would be utterly broken without them.
I thought that freeze period is for us for merge fixes (and this is one). I believe this patch (and the other too) has no impact on non-s390 arches AND fixes 6.0.0 for the s390. And for "utterly broken" - I don't think that's the rule per se. I think we need to evaluate each patch individually. Michal