Re: [libvirt] [PATCH] Remove new lines from debug messages

> Looks good, I would squash in the following: > > diff --git a/src/util/virnetdevmacvlan.c b/src/util/virnetdevmacvlan.c > index f85bd3e..6e00107 100644 > --- a/src/util/virnetdevmacvlan.c > +++ b/src/util/virnetdevmacvlan.c > @@ -565,8 +565,7 @@ virNetDevMacVLanVPortProfileCallback(struct > nlmsghdr *hdr, > } > if (nla_parse_nested(tb3, IFLA_PORT_MAX, tb_vf_ports, > ifla_port_policy)) { > - VIR_DEBUG("nested parsing on level 2" > - " failed"); > + VIR_DEBUG("nested parsing on level 2 failed"); > } > if (tb3[IFLA_PORT_VF]) { > VIR_DEBUG("IFLA_PORT_VF = %d", > > and note in the commit message that you're also removing > trailing full stops from the messages. I dropped this hunk completely, removing full stops deserves a separate patch since we have a lot of them.

> Are those exceptions or did you just miss them? If the > latter, adding a syntax-check for this is probably a good > idea :) Unfortunately, they are exceptions and that's why I didn't add a syntax-check rule.