Re: [libvirt PATCH v6 29/30] nodedev: factor out function to add mediated devices

On Fri, Mar 26, 2021 at 11:48:25AM -0500, Jonathon Jongsma wrote:

To accomodate re-use of this functionality in a following patch, split out the processing of an individual mdev definition into a separate function. --- src/node_device/node_device_driver.c | 103 +++++++++++++++------------ 1 file changed, 57 insertions(+), 46 deletions(-)

diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_device_driver.c index 31322e3afb..35db24817a 100644 --- a/src/node_device/node_device_driver.c +++ b/src/node_device/node_device_driver.c @@ -1506,6 +1506,60 @@ removeMissingPersistentMdevs(virNodeDeviceObj *obj, }

If you move the function to the correct place as mentioned in 30/30: Reviewed-by: Erik Skultety <eskultet@redhat.com>