Re: [PATCH 08/31] configure: ensure dependency for cross-compile setup
Il lun 25 set 2023, 18:45 Alex Bennée <alex.bennee(a)linaro.org> ha scritto:
Paolo Bonzini <pbonzini(a)redhat.com> writes:
> On 9/25/23 16:48, Alex Bennée wrote:
>> echo "HOST_GDB_SUPPORTS_ARCH=y" >>
"$config_target_mak"
>> fi
>> + echo "$config_target_mak: configure" >>
Makefile.prereqs
>
> This in practice is not adding anything; if "configure" changes then
> Makefile's dependency on config-host.mak will trigger a configure
> rerun anyway.
>
> If you want to add it, you should also add it for other config-*.mak
> files. However, I'd remove this line and just change
>
> -# 1. ensure config-host.mak is up-to-date
> +# 1. ensure config-host.mak is up-to-date. All other config-*.mak
> +# files for subdirectories will be updated as well.
Peter ran into a mismatch between config-host.mak and
tests/tcg/foo/config-target.mak in his build system so it didn't get
picked up at one point.
But what is the rule that the new dependency is going to trigger? As far as
I can see there is no rule to regenerate the $config_target_mak files, and
also no rule to regenerate configure; the only effect of a change to
configure will be rerunning the script, but that's triggered by the
existing config-host.mak rule.
Paolo
>
> in the Makefile.
>
> Paolo
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Attachments:
- attachment.html (text/html — 2.2 KB)