Re: [libvirt] [PATCHv3] lxc veth interfaces: fix interface name collisions
On 02/10/13 14:30, Daniel P. Berrange wrote:
On Wed, Oct 02, 2013 at 11:45:27AM +0300, Oskari Saarenmaa wrote:
> This does change the interface names from nice low integers to random larger
> integers, but I don't see that an issue. And the caller can select any
> other name they like if that's not acceptable.
I think having 20 digit NICs names is pretty fugly. It is possible to
address the race condition by re-trying creation with new names. I will
post patches todo this.
I doubt a lot people look at the interface names and care what they are
(especially on servers with dozens of virtual interfaces). Also, with
the new 'consistent network device naming' my desktop's interface name
changed from eth0 to enp0s25 which was a bit annoying at first but makes
a lot of sense with multiple devices.
I think it would've also made sense to make the host interface names for
containers and vms consistent, but with the limited (16 byte) size of
the interface name we can't stuff the whole vm name there; a MAC address
seemed like a good compromise to me and made the code shorter and simpler.
Anyway, enough bikeshedding, I'm happy that the conflicts are getting fixed.
Thanks,
Oskari