Re: [libvirt] [PATCH 1/6] qemuBuildPCIHostdevDevStr: Always format PCI domain onto cmd line
On 7/31/19 10:36 AM, Daniel P. Berrangé wrote:
On Wed, Jul 31, 2019 at 10:32:19AM +0200, Michal Privoznik wrote:
> QEMU is perfectly capable of dealing with fully expanded PCI
> address. Format PCI domain always as it will simplify next
> commits.
Are you sure about that for old QEMUs ? I have a feeling that
it did not support that in the past.
It's not only the commit that Jano referred to, but also the commit that
introduced PCI address parsing in QEMU supports this from the very
beginning v1.2.0-rc0~242^2~4. Therefore I think we can safely assume all
QEMUs we care about are capable of dealing with PCI domain. But let me
record this in commit message to avoid confusion. The new commit mesage
now reads:
qemuBuildPCIHostdevDevStr: Always format PCI domain onto cmd line
While it's true that older QEMUs were not able to deal with PCI
domains, we don't support those versions anymore (see
4a42ece13a538). Therefore it is safe to always format fully
expanded PCI address. Format PCI domain always as it will
simplify next commits.
Michal