Re: [libvirt] [PATCH v3 15/26] qemu: Automatically pick target index and model for pci-root controllers

26 Jun 2017

      On Mon, 2017-06-26 at 14:19 +0530, Shivaprasad bhat wrote:
...
...

+/**
+ * qemuDomainAddressFindNewTargetIndex:
+ * @def: domain definition
+ *
+ * Find a target index that can be used for a PCI controller.
+ *
+ * Returns: an unused target index, or -1 if all available target
+ *          indexes are already taken.
+ */
+static int
+qemuDomainAddressFindNewTargetIndex(virDomainDefPtr def)

May be rename to qemuDomainAddressFindNewPCIRootTargetIndex ?
The name's pretty long as it is, but you're right that the
function is only called for PCI Root controllers and embeds
knowledge about spapr-pci-host-bridge. I'll think about it.

-- 
Andrea Bolognani / Red Hat / Virtualization