Re: [libvirt] [PATCH v2] Fix error reporting when fetching SCSI/LVM keys

From: "Daniel P. Berrange" <berrange(a)redhat.com&gt; The current virStorageFileGet{LVM,SCSI}Key methods return the key as the return value. Unfortunately it is desirable for "NULL" to be a valid return value, as well as an error indicator. Thus the returned key must instead be provided as an out-parameter. When we invoke lvs or scsi_id to extract ID for block devices, we don't want virCommandWait logging errors messages. Thus we must explicitly check 'status != 0', rather than letting virCommandWait do it. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com&gt; --- src/util/storage_file.c | 74 ++++++++++++++++++++++++++++++++----------------- src/util/storage_file.h | 6 ++-- 2 files changed, 53 insertions(+), 27 deletions(-)