-----Original Message----- From: Daniel P. Berrangé <berrange@redhat.com> Subject: Re: [PATCH rfcv4 01/13] tools: Secure guest check for Intel in virt- host-validate
On Fri, May 24, 2024 at 02:21:16PM +0800, Zhenzhong Duan wrote:
Add check in virt-host-validate for secure guest support on x86 for Intel Trust Domain Extentions.
Suggested-by: Daniel P. Berrangé <berrange@redhat.com> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com> --- tools/virt-host-validate-common.c | 22 +++++++++++++++++++++- tools/virt-host-validate-common.h | 1 + 2 files changed, 22 insertions(+), 1 deletion(-)
diff --git a/tools/virt-host-validate-common.c b/tools/virt-host-validate- common.c index c8a23e2e99..4f0698b8ce 100644 --- a/tools/virt-host-validate-common.c +++ b/tools/virt-host-validate-common.c @@ -43,7 +43,8 @@ VIR_ENUM_IMPL(virHostValidateCPUFlag, "svm", "sie", "158", - "sev"); + "sev", + "tdx_host_platform");
I don't think we need to be quiet so verbose here. I think it is sufficient to just call it 'tdx'.
This string is used to compare with output of /proc/cpuinfo. So we can't use 'tdx', or else string compare will fail. Thanks Zhenzhong