Re: [libvirt] [PATCH v2 2/2] qemu_process: don't print empty line if qemu exits without any error

On Wed, Jun 08, 2016 at 12:37:36 +0200, Pavel Hrdina wrote:

Resolves: Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1335617

s/^Resolves: //

Signed-off-by: Pavel Hrdina <phrdina@redhat.com> --- src/qemu/qemu_process.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 87c1fe8..397dac7 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -1809,8 +1809,11 @@ qemuProcessReportLogError(qemuDomainLogContextPtr logCtxt, return -1;

virResetLastError(); - virReportError(VIR_ERR_INTERNAL_ERROR, - _("%s: %s"), msgprefix, logmsg); + if (virStringIsEmpty(logmsg)) + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", msgprefix); + else + virReportError(VIR_ERR_INTERNAL_ERROR, _("%s: %s"), msgprefix, logmsg);

Stupid syntax check. I think the translators really like this string. ACK