Re: [libvirt] PATCH: 23/25: Add domain events to test driver
Jim Meyering <jim(a)meyering.net> wrote:
"Daniel P. Berrange" <berrange(a)redhat.com> wrote:
> On Tue, Jan 13, 2009 at 05:48:12PM +0000, Daniel P. Berrange wrote:
>> This adds support for the domain events in the test driver. Code
>> is following the same pattern as the impl in the QEMU driver.
>>
>> test.c | 223 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
>> 1 file changed, 217 insertions(+), 6 deletions(-)
>
> Updated patch to not queue events if no event loop impl is defined
> (as is common from virsh). This is what was breaking the tests cases
Thanks!
With that, there's only one failure remaining:
35) Xen SEXPR-2-XML fv-sound-all -> fv-sound-all ... FAILED
FAIL: sexpr2xmltest
In your 25-patch series, the new syntax check rule,
sc_prohibit_nonreentrant (nice!) fails because it finds
lots of uses of strerror. Did I miss a patch? This looks
like the change I would have expected to remove those:
Remove use of strerror()
http://git.et.redhat.com/?p=libvirt.git;a=commitdiff;h=9d17447c64a54ab620f6b
Here's a sample:
src/uml_driver.c:796: errno, strerror(errno));
src/uml_driver.c:806: errno, strerror(errno));
src/qemu_driver.c:1029: errno, strerror(errno));
src/storage_conf.c:1351: configDir, strerror(errno));
src/console.c:131: strerror(errno));
src/iptables.c:250: rules->path, strerror(err));
qemud/qemud.c:207: type, file, strerror(errno), errno);
Also, I needed this patch to get past a po-check failure:
diff --git a/po/POTFILES.in b/po/POTFILES.in
index 3d5e715..49b72e7 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -15,6 +15,7 @@ src/network_conf.c
src/network_driver.c
src/node_device.c
src/node_device_conf.c
+src/nodeinfo.c
src/openvz_conf.c
src/openvz_driver.c
src/proxy_internal.c