Re: [libvirt] [PATCH 12/12] tests/domaincaps: Use testQemuCapsIterate()
On Thu, 2019-10-24 at 16:37 +0200, Jiri Denemark wrote:
On Wed, Oct 23, 2019 at 12:43:02 +0200, Andrea Bolognani wrote:
> + /*
> + * Run "tests/qemucapsprobe /path/to/qemu/binary >foo.replies"
> + * to generate updated or new *.replies data files.
> + *
> + * If you manually edit replies files you can run
> + * "tests/qemucapsfixreplies foo.replies" to fix the replies ids.
> + *
> + * Once a replies file has been generated and tweaked if necessary,
> + * you can drop it into tests/qemucapabilitiesdata/ (with a sensible
> + * name - look at what's already there for inspiration) and test
> + * programs will automatically pick it up.
> + *
> + * To generate the corresponding output files after a new replies
> + * file has been added, run "VIR_TEST_REGENERATE_OUTPUT=1 make
check".
> + */
I'd just suggest running
VIR_TEST_REGENERATE_OUTPUT=1 tests/qemucapabilitiestest
followed by
VIR_TEST_REGENERATE_OUTPUT=1 tests/domaincapstest
The comment is the same as qemucapabilitiestest and qemucaps2xmltest,
so we'd have to update those as well... On the other hand, the actual
problem is arguably the fact that we have replicated it in the first
place.
I'll try to come up with a better solution and post a separate patch
addressing this issue; in the meantime, I've pushed the series as
posted on the list. Thanks for your review! :)
--
Andrea Bolognani / Red Hat / Virtualization