This series address the same issue as seemingly abandomed patch series [1].
Implementation is written from scratch however as I don't see need to introduce
new flags for the purpose of this patch series. However I read John's comments
and addressed them where applied. The option for not reverting inactive config
in case of restoring active persistent domain that Jiri suggested in [2] is new
functionality actually and is left for future work.
The purpuse of patch series is described in patch 3
"qemu: snapshot: save/restore inactive persistent config":
In case of active persistent domain snapshot metadata is
not complete. We save only active configuration and on
restore use it both for active and inactive configuration.
Let's fix it and save and restore both in this case.
[1] [PATCH 0/7] Keep non-persistent changes alive in snapshot
https://www.redhat.com/archives/libvir-list/2017-October/msg01333.html
[2] [PATCH] qemu: snapshot: Keep non-persistent changes alive in snapshot
https://www.redhat.com/archives/libvir-list/2017-October/msg01275.html
Nikolay Shirokovskiy (9):
qemu: release job on cleanup path
qemu: snapshot revert: reuse common cleanup code
qemu: snapshot: save/restore inactive persistent config
schema: snapshot: add persistent domain config
conf: snapshot: dump/parse persistent domain config
docs: add persistent config to snapshot xml description
conf: snapshot: check domain name on redefine
conf: snapshot: support persistent config on redefine
news: add notice for persistent config in snapshot
docs/formatsnapshot.html.in | 7 ++
docs/news.xml | 11 +++
docs/schemas/domainsnapshot.rng | 10 +++
src/conf/snapshot_conf.c | 60 +++++++++++++++
src/conf/snapshot_conf.h | 2 +
src/qemu/qemu_driver.c | 52 ++++++++++---
.../active_inactive_domain.xml | 85 ++++++++++++++++++++++
tests/domainsnapshotxml2xmltest.c | 1 +
8 files changed, 218 insertions(+), 10 deletions(-)
create mode 100644 tests/domainsnapshotxml2xmlout/active_inactive_domain.xml
--
1.8.3.1