Re: [libvirt] [PATCH 6/6] qemu: Add support for host CPU modes

On 01/06/2012 08:04 AM, Jiri Denemark wrote: Also a bit light on the commit message. Thanks for enhancing the testsuite; as time-consuming as it is, it always has a good payout in preventing regressions. Should this be chmod +x? I guess since you are sourcing the file, it doesn't matter if it the helper file is executable; it is just division of labor. s/source/./ (the spelled-out name is a bash extension not guaranteed by POSIX). fgrep is not standard (although it's likely to exist on all platforms where qemu exists). In isolation, [ doesn't need shell quoting (although seeing quotes around a grep script makes it obvious what pattern you are looking for). I'd use either: faked_cpu | grep -Fv '[' faked_cpu | grep -v '\[' Again, s/source/./ -- Eric Blake eblake(a)redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org