Re: [PATCH] libvirt qemu add rbd mirror dest in qemuDomainBlockCopyCommon

On Sat, Oct 09, 2021 at 15:55:54 +0800, dinglimin(a)cmss.chinamobile.com wrote: > From: dinglimin <dinglimin(a)cmss.chinamobile.com&gt; > > The BlockCopy command is designed to copy a chain of disk backup images to dest. > For RBD external destination, before the modification, only the '--XML' parameter is supported by 'blockdev-mirror'. > After the modification, the '--dest' parameter(--dest 'rbd:xxx/xxx:auth_supported=none:mon_host=xxx.xxx.xxx.xxx')can be used. > > Signed-off-by: dinglimin <dinglimin(a)cmss.chinamobile.com&gt; > --- > src/qemu/qemu_driver.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+)

NACK, the correct approach is as you mention in the commit message is to use the "--xml" parameter of 'virsh blockcopy' to pass a XML describing the RBD destionation. We don't want to add a hack to do this via the --dest parameter. Use the XML.