On Tue, 2020-05-12 at 11:21 +0100, Daniel P. Berrangé wrote:
+.container_job_template: &container_job_definition + image: docker:stable + stage: containers + services: + - docker:dind + before_script: + - export TAG="$CI_REGISTRY_IMAGE/ci-$NAME:latest" + - export COMMON_TAG="$CI_REGISTRY/libvirt/ruby-libvirt/ci-$NAME:latest"
Can we rename the repo to libvirt-ruby already?
+.dist_build_job_template: &dist_build_job_definition + image: $CI_REGISTRY_IMAGE/ci-$NAME:latest + stage: builds + before_script: + - export MAKEFLAGS="-j$(getconf _NPROCESSORS_ONLN)" + script: + - rake build + - if test "$NAME" != "opensuse-151" ; then rake package; fi
Same comment made for the Java bindings: please make this an optional part of the build that can be skipped by using the appropriate variable at job definition time. Everything else looks good. -- Andrea Bolognani / Red Hat / Virtualization