Re: [libvirt] [PATCHv2] storage: avoid null deref and leak on failure

On 05/04/2011 11:56 AM, Laine Stump wrote:

On 05/04/2011 12:52 PM, Eric Blake wrote:

...

Detected by clang. NULL deref added in commit 343a27a (Mar 11), but leak of voldef present since commit 2cd9b2d (Apr 09).

* src/storage/storage_driver.c (storageVolumeCreateXML): Don't leak voldef or dereference null volobj. ---

v2: don't leave pool->volumes.objs pointing to stale memory on failure

ACK.

Thanks; pushed. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org