Re: [libvirt] [PATCH 02/41] domcaps: Add support for listing supported CPU models

> +int > +virDomainCapsCPUModelsAddSteal(virDomainCapsCPUModelsPtr cpuModels, > + char **name) > +{ > + if (VIR_RESIZE_N(cpuModels->models, cpuModels->alloc, > + cpuModels->count, 1) < 0) > + return -1; > + > + cpuModels->models[cpuModels->count++].name = *name; > + *name = NULL; Similar to VIR_STEAL_PTR with the added count++ twist...

> diff --git a/src/conf/domain_capabilities.h b/src/conf/domain_capabilities.h > index 492a9cf..509c306 100644 > --- a/src/conf/domain_capabilities.h > +++ b/src/conf/domain_capabilities.h > @@ -102,6 +102,30 @@ struct _virDomainCapsFeatureGIC { > virDomainCapsEnum version; /* Info about virGICVersion */ > }; > > +typedef struct _virDomainCapsCPUModel virDomainCapsCPUModel; > +typedef virDomainCapsCPUModel *virDomainCapsCPUModelPtr; > +struct _virDomainCapsCPUModel { > + char *name; > +}; > + > +typedef struct _virDomainCapsCPUModels virDomainCapsCPUModels; > +typedef virDomainCapsCPUModels *virDomainCapsCPUModelsPtr; > +struct _virDomainCapsCPUModels { > + virObject parent; > + > + size_t alloc; > + size_t count; Easier for me to read/see "->nmodels_max" and "->nmodels"... Not sure how pervasive it is to change... Not a requirement, your call...